Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: don't add reviewers if a CL has the wait-release hashtag #28945

Open
mvdan opened this issue Nov 25, 2018 · 0 comments

Comments

@mvdan
Copy link
Member

commented Nov 25, 2018

Take for example https://go-review.googlesource.com/c/go/+/151197. I mailed this during the freeze with the wait-release hashtag, precisely because I don't want to bother other contributors and reviewers until the tree reopens.

This is futile though, as Gobot proceeds to ping a dozen people. It has happened on a bunch of CLs I've sent this weekend, and I worry I've been spamming people.

I presume that gerritbot should also not assign reviewers to CLs with DO NOT REVIEW. I'm not sure if that is implemented already.

/cc @andybons @dmitshur @bradfitz

@gopherbot gopherbot added this to the Unreleased milestone Nov 25, 2018

@gopherbot gopherbot added the Builders label Nov 25, 2018

@andybons andybons changed the title x/build/cmd/gerritbot: don't add reviewers if a CL has the wait-release hashtag x/build/cmd/gopherbot: don't add reviewers if a CL has the wait-release hashtag Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.