Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: use cmd/go's build caching #28950

Open
bradfitz opened this issue Nov 26, 2018 · 5 comments
Open

x/build/cmd/coordinator: use cmd/go's build caching #28950

bradfitz opened this issue Nov 26, 2018 · 5 comments

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 26, 2018

Now that cmd/go has good caching, cmd/coordinator should use it, somehow.

We'd likely need some hooks in cmd/go to accommodate our needs, but Russ said he was fine with that when I asked him maybe a year ago.

/cc @dmitshur @bcmills

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Nov 26, 2018

Isn't the build cache tied to a specific compiler version? As soon as the compiler changes just a bit, every package would need to be rebuilt.

Can you elaborate on how the build cache could be used by cmd/coordinator?

Loading

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Nov 26, 2018

Many CLs don't affect the compiler. (std changes, doc updates, etc)

And today we effectively build+test everything twice: trybots and then again for post-submit builds.

Loading

@mvdan
Copy link
Member

@mvdan mvdan commented Nov 26, 2018

Would both the trybots and builders use caching? I presume that trybots are the ones where total run-time matters the most.

I agree that this would be a good step forward. One possible disadvantage I can see is that we would test the compiler less often. It's easier to catch flakes and very unlikely crashes in the compiler if every builder compiles the entirety of Go at every run. I wonder if it would be a problem if we lost that, though.

Loading

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 26, 2018

I don't recall seeing much flakiness in the compiler itself, nor the assembler nor linker. I think it's OK to run them less often.

Loading

@bcmills
Copy link
Member

@bcmills bcmills commented Nov 27, 2018

If we have spare capacity and want to use it to check for flakiness, we can always issue extra builds with clean caches (or with GODEBUG=gocacheverify=1).

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants