x/build/cmd/coordinator: use cmd/go's build caching

[bradfitz]

Now that cmd/go has good caching, cmd/coordinator should use it, somehow.

We'd likely need some hooks in cmd/go to accommodate our needs, but Russ said he was fine with that when I asked him maybe a year ago.

/cc @dmitshur @bcmills

[dmitshur]

Isn't the build cache tied to a specific compiler version? As soon as the compiler changes just a bit, every package would need to be rebuilt.

Can you elaborate on how the build cache could be used by cmd/coordinator?

[bradfitz]

Many CLs don't affect the compiler. (std changes, doc updates, etc)

And today we effectively build+test everything twice: trybots and then again for post-submit builds.

[mvdan]

Would both the trybots and builders use caching? I presume that trybots are the ones where total run-time matters the most.

I agree that this would be a good step forward. One possible disadvantage I can see is that we would test the compiler less often. It's easier to catch flakes and very unlikely crashes in the compiler if every builder compiles the entirety of Go at every run. I wonder if it would be a problem if we lost that, though.

[ianlancetaylor]

I don't recall seeing much flakiness in the compiler itself, nor the assembler nor linker. I think it's OK to run them less often.

[bcmills]

If we have spare capacity and want to use it to check for flakiness, we can always issue extra builds with clean caches (or with GODEBUG=gocacheverify=1).