Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode: generated comments have redundant information #28954

Closed
emilyselwood opened this issue Nov 26, 2018 · 3 comments
Closed

unicode: generated comments have redundant information #28954

emilyselwood opened this issue Nov 26, 2018 · 3 comments

Comments

@emilyselwood
Copy link
Contributor

@emilyselwood emilyselwood commented Nov 26, 2018

What version of Go are you using (go version)?

$ go version
go version go1.11 linux/amd64

Does this issue reproduce with the latest release?

yes

What did you do?

Looked at the documentation for the Unicode package. The package variables part contains some redundant information in the category descriptions.

https://golang.org/pkg/unicode/#pkg-variables

When I look at the comments there I have to go away and look up what the category descriptions are so I know which category I need. It would be much better to have the category description included in the comments.

@emilyselwood
Copy link
Contributor Author

@emilyselwood emilyselwood commented Nov 26, 2018

I've made a fix for this. I'll send along a CL shortly.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 26, 2018

Change https://golang.org/cl/151297 mentions this issue: unicode: improve generated comments for categories

@andybons andybons added this to the Unplanned milestone Nov 26, 2018
@andybons
Copy link
Member

@andybons andybons commented Nov 26, 2018

@gopherbot gopherbot closed this in d704b5c Nov 28, 2018
@golang golang locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.