Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: inline multiplication corrupts an argument on arm [1.10 backport] #28959

Closed
andybons opened this Issue Nov 26, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@andybons
Copy link
Member

andybons commented Nov 26, 2018

Manually opening this due to gopherbot not tracking follow-up backport requests.

Issue #28688 is to be considered for backport to the next 1.10 minor release.

@josharian @milanknezevic

@andybons andybons added this to the Go1.10.6 milestone Nov 26, 2018

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Nov 27, 2018

Change https://golang.org/cl/151343 mentions this issue: [release-branch.go1.10] cmd/compile/internal/gc: OMUL should be evaluated when using soft-float

@dmitshur dmitshur modified the milestones: Go1.10.6, Go1.10.7 Dec 13, 2018

gopherbot pushed a commit that referenced this issue Dec 14, 2018

[release-branch.go1.10] cmd/compile/internal/gc: OMUL should be evalu…
…ated when using soft-float

When using soft-float, OMUL might be rewritten to function call
so we should ensure it was evaluated first.

Updates #28688
Fixes #28959

Change-Id: I30b87501782fff62d35151f394a1c22b0d490c6c
Reviewed-on: https://go-review.googlesource.com/c/148837
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
(cherry picked from commit c92e73b)
Reviewed-on: https://go-review.googlesource.com/c/151343
Reviewed-by: Filippo Valsorda <filippo@golang.org>
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Dec 14, 2018

Closed by merging d74e69c to release-branch.go1.10.

@gopherbot gopherbot closed this Dec 14, 2018

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Dec 14, 2018

Change https://golang.org/cl/154297 mentions this issue: Revert "[release-branch.go1.10] cmd/compile/internal/gc: OMUL should be evaluated when using soft-float"

gopherbot pushed a commit that referenced this issue Dec 14, 2018

Revert "[release-branch.go1.10] cmd/compile/internal/gc: OMUL should …
…be evaluated when using soft-float"

This reverts commit d74e69c.

Reason for revert: this fix has been backported to 1.11, and that makes
it ineligible for backport to 1.10, since upgrading to 1.11 is a valid
workaround according to https://github.com/golang/go/wiki/MinorReleases.

Also, this triggers a bug on Wasm that would require a backport of
CL 149965, too.

Updates #28688
Updates #28959

Change-Id: I4e56554ea27b5db83bdb1e9d2103dd24e3da8cfc
Reviewed-on: https://go-review.googlesource.com/c/154297
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.