x/build/maintner: isTempError improvements #28994
Labels
Builders
x/build issues (builders, bots, dashboards)
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Currently
isTempError
logs the error and vacuously returns trueThis is used in the
sync
function's error group members in conjunction withloop
to determine if the error returned from the various sourcesync
functions is a temporary error or not.This guarantees that if
SyncLoop
is called, the routines will loop forever (loop
is true andisTempErr
always returns true), but it also means that ifSync
is called, and any repository sync operation fails, the entire error group will exit. In acorpus
that is tracking hundreds of repositories with tens of thousands of issues, a single temporary error in theSync
call will always abort all other routines in the group.It would be useful to be able to provide criteria for what constitutes a temporary error or not.
I propose something similar to the following:
This would give the consumers of
corpus
the ability to determine what constitutes a temporary error, but default back to the old behaviour by passingnil
toSync
andSyncLoop
The text was updated successfully, but these errors were encountered: