Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestExecBuildX is too sensitive to GOROOT #29004

Closed
bcmills opened this issue Nov 29, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@bcmills
Copy link
Member

commented Nov 29, 2018

When making changes to cmd/go (and not other parts of the standard library or toolchain), most of the test cases in go test cmd/go continue to pass without rebuilding. However, TestExecBuildX seems to fail pretty reliably unless make.bash has been run at the exact commit being tested.

That's a bit annoying, because make.bash itself is pretty slow. I'd like to figure out whether we can make TestExecBuildX more robust to changes.

@bcmills bcmills added this to the Go1.13 milestone Nov 29, 2018

@bcmills bcmills self-assigned this Nov 29, 2018

@gopherbot

This comment has been minimized.

Copy link

commented Jun 25, 2019

Change https://golang.org/cl/183838 mentions this issue: cmd/go: ensure that runtime/cgo is not stale in TestExecBUildX

@gopherbot gopherbot closed this in 3f83c83 Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.