New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: improve `go help goproxy` #29009

Open
hyangah opened this Issue Nov 29, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@hyangah
Contributor

hyangah commented Nov 29, 2018

'go help goproxy' describes the module proxy protocol, and it needs to document more details to guide correct proxy implementation.

  1. 'go get; issues a /latest query to go proxy, (https://go.googlesource.com/go/+/master/src/cmd/go/internal/modfetch/proxy.go#185) but this type of query is not documented.

  2. document what's the expected results for for non modules.
    For example, what's the expected results or error code for the following module or package?

 
   golang.org/x/tools/@v/list
   golang.org/x/tools/@latest
   golang.org/x/tools/go/@latest

   github.com/rogpeppe/godef/go/@v/list
   github.com/rogpeppe/godef/go/@latest
  1. specify appropriate error codes the go command expects for various error conditions.

@bcmills @rsc

@bcmills bcmills added the NeedsFix label Nov 29, 2018

@bcmills bcmills self-assigned this Nov 29, 2018

@bcmills bcmills added this to the Go1.12 milestone Nov 29, 2018

@bcmills

This comment has been minimized.

Member

bcmills commented Nov 29, 2018

@bcmills bcmills added the modules label Nov 29, 2018

@hyangah

This comment has been minimized.

Contributor

hyangah commented Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment