New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/internal/xcoff: move to x/debug/xcoff #29038

Open
Helflym opened this Issue Nov 30, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@Helflym
Contributor

Helflym commented Nov 30, 2018

Hi,

Since CL 149957, the tests inside gccgoimporter as long as the gccgo command is available, which is the case on most of AIX machines. However, it's only aware of ELF gccgo files, it doesn't recognize XCOFF files. To add the features, cmd/internal/xcoff must be moved to x/debug/xcoff as it was suggested by issue 28037.
Is that possible ?

Morever, big archive format is only available on AIX, as far as I know. Therefore, is that okay if I implement functions to read them in x/debug/xcoff ? Or I'd rather do a x/debug/ar as it was suggested here:
https://github.com/golang/go/blob/master/src/cmd/internal/buildid/buildid.go#L121

/cc @ianlancetaylor @bradfitz

@ianlancetaylor ianlancetaylor added this to the Go1.12 milestone Nov 30, 2018

@ianlancetaylor

This comment has been minimized.

Contributor

ianlancetaylor commented Nov 30, 2018

CC @rsc

I don't think we've really decided what is happening with x/debug. Or if we did, I've forgotten.

Note that we could keep postponing that and address this issue by moving cmd/internal/xcoff to internal/xcoff.

@Helflym

This comment has been minimized.

Contributor

Helflym commented Nov 30, 2018

I haven't thought about internal/xcoff. I'd rather have x/debug/xcoff as it could be used by anyone as debug/elf or debug/macho currently are. But it's as you wish.

@bradfitz

This comment has been minimized.

Member

bradfitz commented Nov 30, 2018

I want to see the aix/ppc64 column all black and "ok" on https://build.golang.org/ before we start doing nice-to-have changes and entering the cherry-picking/branch-management world.

@bradfitz bradfitz modified the milestones: Go1.12, Go1.13 Nov 30, 2018

@bradfitz

This comment has been minimized.

Member

bradfitz commented Nov 30, 2018

Moving to Go 1.13 for now. If AIX is in good shape soon then we could probably do this during the freeze, but it's not important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment