New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/packages: support file= queries against overlay files #29048

Closed
ianthehat opened this Issue Nov 30, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@ianthehat
Copy link

ianthehat commented Nov 30, 2018

As of cl/151999 we support adding new files in the overlay.
It is highly likely that any file that was added in an overlay is also going to be used in file= queries, as that is what all the editor tools will be doing.
At the moment we check the results of go list for a package that contains the file, which will not have any of the overlay files in it, it should be fairly easy to do that check after the overlay additions instead of before, to enable this use case.

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Dec 5, 2018

Change https://golang.org/cl/152797 mentions this issue: go/packages: check for containing files after overlay is processed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment