cmd/vet: ambiguous path for filename in repeated json tag warning #29130
Comments
Indeed a bug. This is because the check was extended to also check anonymous fields, whose type definition may be in a different package. So taking the file path basename is no longer enough to point to the relevant file. Should be simple enough to fix, and it's a regression in 1.12 since the check was extended in the last few months. Will have a look this weekend. /cc @alandonovan |
Change https://golang.org/cl/156378 mentions this issue: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is a followup issue to #28995.
What version of Go are you using (
go version
)?What did you do?
I ran
go vet ./http
andcd ./http; go vet .
against github.com/influxdata/platform at revision 5da9d37b5b3d83056313ed5f6e50e529af52734e, master as of sometime today. (Of course, we should have fixed the vet error by now, but it has been helpful to work out some vet issues here, at least.)I expected the warning to use either an explicit relative path like
./dashboard.go:53
or../dashboard.go:53
; or a package-relative path likegithub.com/influxdata/platform/dashboard.go:53
.The text was updated successfully, but these errors were encountered: