Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upnet/http: useless string replace operation in Cookie.String #29135
Comments
bronze1man
changed the title from
[net/http] useless string replace in Cookie.String
to
[net/http] useless string replace operation in Cookie.String
Dec 7, 2018
mvdan
changed the title from
[net/http] useless string replace operation in Cookie.String
to
net/http: useless string replace operation in Cookie.String
Dec 7, 2018
mvdan
added
the
NeedsDecision
label
Dec 7, 2018
This comment has been minimized.
This comment has been minimized.
|
/cc @bradfitz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bronze1man commentedDec 7, 2018
isCookieNameValid do not allow "\r" "\n" appear in the cookie name.
https://github.com/golang/go/blob/master/src/net/http/cookie.go#L168
https://github.com/golang/go/blob/master/src/net/http/http.go#L50
https://github.com/golang/go/blob/master/src/internal/x/net/http/httpguts/httplex.go#L15
sanitizeCookieName replace "\r" "\n" to "-"
https://github.com/golang/go/blob/master/src/net/http/cookie.go#L172
This replace operation should have no effect.So it can be delete to save cpu time and make code easier to read.