Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: useless string replace operation in Cookie.String #29135

Closed
bronze1man opened this issue Dec 7, 2018 · 6 comments

Comments

Projects
None yet
4 participants
@bronze1man
Copy link
Contributor

commented Dec 7, 2018

This replace operation should have no effect.So it can be delete to save cpu time and make code easier to read.

@bronze1man bronze1man changed the title [net/http] useless string replace in Cookie.String [net/http] useless string replace operation in Cookie.String Dec 7, 2018

@mvdan mvdan changed the title [net/http] useless string replace operation in Cookie.String net/http: useless string replace operation in Cookie.String Dec 7, 2018

@mvdan mvdan added the NeedsDecision label Dec 7, 2018

@mvdan

This comment has been minimized.

Copy link
Member

commented Dec 7, 2018

/cc @bradfitz

@mvdan

This comment has been minimized.

Copy link
Member

commented Jan 5, 2019

@bronze1man do you plan on sending this as a CL for 1.13? In general it should be fine to send CLs without an issue, unless there's a bug to be tracked. Otherwise, if you don't plan on sending the CL, we can just close this issue.

@bradfitz bradfitz added this to the Go1.13 milestone Jan 5, 2019

@bronze1man

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2019

Thanks for mention, I just find this bug when i read the source code.
Sorry, I do not try to send a CL at when i add the issue.
I will try to send a CL soon.

@gopherbot

This comment has been minimized.

Copy link

commented Jan 14, 2019

Change https://golang.org/cl/157777 mentions this issue: net/http: useless string replace operation in Cookie.String. Fixes #29135

@bradfitz

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Closing so I can take this over on Gerrit.

@bradfitz bradfitz closed this Apr 15, 2019

@bradfitz

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

I meant to close the PR.

@bradfitz bradfitz reopened this Apr 15, 2019

@gopherbot gopherbot closed this in 09b2b6e Apr 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.