Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upnet/http: useless string replace operation in Cookie.String #29135
Comments
bronze1man
changed the title
[net/http] useless string replace in Cookie.String
[net/http] useless string replace operation in Cookie.String
Dec 7, 2018
mvdan
changed the title
[net/http] useless string replace operation in Cookie.String
net/http: useless string replace operation in Cookie.String
Dec 7, 2018
mvdan
added
the
NeedsDecision
label
Dec 7, 2018
This comment has been minimized.
This comment has been minimized.
|
/cc @bradfitz |
This comment has been minimized.
This comment has been minimized.
|
@bronze1man do you plan on sending this as a CL for 1.13? In general it should be fine to send CLs without an issue, unless there's a bug to be tracked. Otherwise, if you don't plan on sending the CL, we can just close this issue. |
bradfitz
added this to the Go1.13 milestone
Jan 5, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks for mention, I just find this bug when i read the source code. |
bradfitz
modified the milestones:
Go1.13,
Unplanned
Jan 7, 2019
bradfitz
added
help wanted
NeedsFix
labels
Jan 7, 2019
gopherbot
removed
the
NeedsDecision
label
Jan 7, 2019
added a commit
to bronze1man/go
that referenced
this issue
Jan 14, 2019
bronze1man
referenced a pull request that will
close
this issue
Jan 14, 2019
Open
net/http: useless string replace operation in Cookie.String. Fixes #29135 #29728
This comment has been minimized.
This comment has been minimized.
gopherbot
commented
Jan 14, 2019
|
Change https://golang.org/cl/157777 mentions this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bronze1man commentedDec 7, 2018
isCookieNameValid do not allow "\r" "\n" appear in the cookie name.
https://github.com/golang/go/blob/master/src/net/http/cookie.go#L168
https://github.com/golang/go/blob/master/src/net/http/http.go#L50
https://github.com/golang/go/blob/master/src/internal/x/net/http/httpguts/httplex.go#L15
sanitizeCookieName replace "\r" "\n" to "-"
https://github.com/golang/go/blob/master/src/net/http/cookie.go#L172
This replace operation should have no effect.So it can be delete to save cpu time and make code easier to read.