Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/parser: fails to parse an invalid switch statement #29148

Open
stamblerre opened this issue Dec 7, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@stamblerre
Copy link
Contributor

commented Dec 7, 2018

Repro case:

package main

import "go/ast"

func main() {
	var node ast.Node
	var lit *ast.CompositeLit
	switch n := node.(type) {
	case *ast.CompositeLit:
		lit = n
                lit.
	case *ast.KeyValueExpr:
	}
}

In this case, lit. case *ast.KeyValueExpr: gets parsed into an *ast.BadStmt. This is a problem for tools that need to work on broken code.

@stamblerre

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2018

@stamblerre stamblerre self-assigned this Dec 7, 2018

@mvdan

This comment has been minimized.

Copy link
Member

commented Dec 9, 2018

Could be interesting to see what cmd/compile/internal/syntax does here. As far as I've seen, it does a better job with edge cases and errors. Though it doesn't seem to have a BadStmt equivalent right now.

@ALTree ALTree added this to the Unplanned milestone Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.