Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: emit an error in 'go mod vendor' if any replacement is in the vendor directory #29169

Open
bcmills opened this issue Dec 10, 2018 · 1 comment
Labels
GoCommand modules NeedsFix
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Dec 10, 2018

There is significant overlap between replace directives and the vendor directory, and users sometimes conflate the two (#29079 (comment)).

Since go mod vendor removes and replaces the entire contents of the vendor directory, it will fail (or at least produce very confusing behavior) if a replace directive points into vendor. We should detect that condition explicitly and emit a useful error.

(CC @jayconrod)

@bcmills bcmills added NeedsFix GoCommand modules labels Dec 10, 2018
@bcmills bcmills added this to the Go1.13 milestone Dec 10, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 6, 2019

Change https://golang.org/cl/156400 mentions this issue: emit an error in 'go mod vendor' if any replacement is in the vendor directory

@andybons andybons removed this from the Go1.13 milestone Jul 8, 2019
@andybons andybons added this to the Go1.14 milestone Jul 8, 2019
@rsc rsc removed this from the Go1.14 milestone Oct 9, 2019
@rsc rsc added this to the Backlog milestone Oct 9, 2019
@smasher164 smasher164 removed this from the Backlog milestone Oct 11, 2019
@smasher164 smasher164 added this to the Go1.14 milestone Oct 11, 2019
@ianlancetaylor ianlancetaylor removed this from the Go1.14 milestone Dec 5, 2019
@ianlancetaylor ianlancetaylor added this to the Backlog milestone Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GoCommand modules NeedsFix
Projects
None yet
Development

No branches or pull requests

6 participants