Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestUDPZeroBytePayload is potentially flaky on iOS #29225

Open
bcmills opened this issue Dec 13, 2018 · 11 comments
Open

net: TestUDPZeroBytePayload is potentially flaky on iOS #29225

bcmills opened this issue Dec 13, 2018 · 11 comments
Labels
mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 13, 2018

Examples:
https://build.golang.org/log/4801b71522ac597735f5dfc9e3de0a5177f1b014
https://build.golang.org/log/ac45684f4eeb9337972d8489ff01b93bf69adef2v
https://build.golang.org/log/bef89502b0ebe850c741f3e69ed9e01d7b497c5a

--- FAIL: TestUDPZeroBytePayload (0.11s)
    udpsock_test.go:369: read udp4 127.0.0.1:49432: i/o timeout
FAIL
FAIL	net	9.988s

CC @mikioh @bradfitz @ianlancetaylor
@bcmills bcmills added OS-Darwin NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 13, 2018
@bcmills bcmills added this to the Go1.12 milestone Dec 13, 2018
@ianlancetaylor
Copy link
Member

I think this is due to CL 132781. I commented on that CL, and will send a CL to revert the change to net/udpsock_test.go.

@ianlancetaylor
Copy link
Member

CC @silbinarywolf

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/154759 mentions this issue: net: accept a timeout from ReadFrom in TestUDPZeroBytePayload

@FiloSottile
Copy link
Contributor

The test is still failing with a slightly different message now:

--- FAIL: TestUDPZeroBytePayload (30.00s)
    udpsock_test.go:367: Read of zero byte packet failed: read udp4 127.0.0.1:53753: i/o timeout

@FiloSottile FiloSottile reopened this Dec 20, 2018
@katiehockman
Copy link
Contributor

This is continuing to fail for darwin-amd64-10_10 builds, though now it looks flaky. It is getting a similar error message as the one that @FiloSottile provided in the previous comment.

--- FAIL: TestUDPZeroBytePayload (30.01s)
    udpsock_test.go:367: Read of zero byte packet failed: read udp4 127.0.0.1:63888: i/o timeout

@FiloSottile FiloSottile added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jan 2, 2019
@silbinarywolf
Copy link
Contributor

silbinarywolf commented Jan 2, 2019 •
edited
Loading

Just as an FYI, I merely followed the direction of the related Github issue when doing the original CL for this and I don't have any ideas on how to resolve this at all. I'm willing to put in the time for another CL if somebody only has time to direct / review my work, however my thinking is somebody with more experience should probably explore this and cover it off.

Sorry I'm not more help!

@ianlancetaylor
Copy link
Member

Looks like it's happening fairly often on Darwin 10.10, not at all on later versions of Darwin.

2018-12-29T00:04:59-14bdcc7/darwin-amd64-10_10
2018-12-29T14:18:11-efbd01f/darwin-amd64-10_10
2018-12-29T17:24:26-58a17b4/darwin-amd64-10_10
2018-12-30T04:55:26-3e89272/darwin-amd64-10_10
2018-12-30T19:36:52-480373c/darwin-amd64-10_10
2018-12-31T22:48:43-ed78c90/darwin-amd64-10_10
2019-01-01T06:18:45-c6282e7/darwin-amd64-10_10
2019-01-01T20:15:48-204a8f5/darwin-amd64-10_10
2019-01-02T16:18:03-ad16449/darwin-amd64-10_10
2019-01-02T16:59:44-8962b71/darwin-amd64-10_10
2019-01-02T17:00:30-2175177/darwin-amd64-10_10
2019-01-02T19:28:06-2e217fa/darwin-amd64-10_10
2019-01-02T19:31:05-5ec5c57/darwin-amd64-10_10
2019-01-02T20:55:53-22738f0/darwin-amd64-10_10
2019-01-02T21:21:53-64096db/darwin-amd64-10_10
2019-01-02T21:49:30-57879fe/darwin-amd64-10_10

@ianlancetaylor
Copy link
Member

I'll send a CL to skip the test on Darwin. Since the Darwin 10.12 builder seems to be consistently passing, I assume it's Darwin 10.10 flakiness that has been fixed since then.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/156119 mentions this issue: net: skip TestUDPZeroBytePayload on Darwin

gopherbot pushed a commit that referenced this issue Jan 3, 2019
@ianlancetaylor
net: skip TestUDPZeroBytePayload on Darwin
0175064 
Updates #29225

Change-Id: I4c9b7a108861ce5c9ab84f7324ced3da51e7bf2a
Reviewed-on: https://go-review.googlesource.com/c/156119
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@bradfitz bradfitz modified the milestones: Go1.12, Unplanned Jan 7, 2019
@bcmills bcmills mentioned this issue Oct 7, 2019
Open
@bcmills
Copy link
Contributor Author

bcmills commented Sep 23, 2022

Since the Darwin 10.12 builder seems to be consistently passing, I assume it's Darwin 10.10 flakiness that has been fixed since then.

Now that we no longer have 10.10 Darwin builders, should we unskip this test?

@bcmills bcmills modified the milestones: Unplanned, Go1.20 Sep 23, 2022
@gopherbot gopherbot modified the milestones: Go1.20, Go1.21 Feb 1, 2023
@gopherbot gopherbot modified the milestones: Go1.21, Go1.22 Aug 8, 2023
@gopherbot gopherbot modified the milestones: Go1.22, Go1.23 Feb 6, 2024
@dmitshur dmitshur modified the milestones: Go1.23, Go1.24 Jul 26, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/601395 mentions this issue: net: unskip TestUDPZeroBytePayload on Darwin

@dmitshur dmitshur changed the title net: TestUDPZeroBytePayload is flaky on darwin-amd64-10_10 net: TestUDPZeroBytePayload is potentially flaky on iOS Jul 26, 2024
@dmitshur dmitshur modified the milestones: Go1.24, Backlog Jul 26, 2024
gopherbot pushed a commit that referenced this issue Jul 26, 2024
@dmitshur @gopherbot
net: unskip TestUDPZeroBytePayload on Darwin
d597642 
From information we have available in the issue, this test was flaky
on OS X 10.10 but not newer. By now macOS 11 is the minimum required
version, and 1000 local runs of the test passed, so try to unskip as
the next step.

For #29225.

Change-Id: I18a24459f01e53ef9de05b50d1dd8786d0683107
Cq-Include-Trybots: luci.golang.try:gotip-darwin-amd64_11,gotip-darwin-amd64_14
Reviewed-on: https://go-review.googlesource.com/c/go/+/601395
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@dmitshur dmitshur added the mobile Android, iOS, and x/mobile label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
8 participants
@bradfitz @FiloSottile @dmitshur @ianlancetaylor @silbinarywolf @bcmills @gopherbot @katiehockman