Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestUDPZeroBytePayload is flaky on darwin-amd64-10_10 #29225

Open
bcmills opened this issue Dec 13, 2018 · 9 comments

Comments

@bcmills
Copy link
Member

commented Dec 13, 2018

@bcmills bcmills added this to the Go1.12 milestone Dec 13, 2018

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2018

I think this is due to CL 132781. I commented on that CL, and will send a CL to revert the change to net/udpsock_test.go.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2018

@gopherbot

This comment has been minimized.

Copy link

commented Dec 18, 2018

Change https://golang.org/cl/154759 mentions this issue: net: accept a timeout from ReadFrom in TestUDPZeroBytePayload

@gopherbot gopherbot closed this in 0dd88cd Dec 20, 2018

@FiloSottile

This comment has been minimized.

Copy link
Member

commented Dec 20, 2018

The test is still failing with a slightly different message now:

--- FAIL: TestUDPZeroBytePayload (30.00s)
    udpsock_test.go:367: Read of zero byte packet failed: read udp4 127.0.0.1:53753: i/o timeout
@katiehockman

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2019

This is continuing to fail for darwin-amd64-10_10 builds, though now it looks flaky. It is getting a similar error message as the one that @FiloSottile provided in the previous comment.

--- FAIL: TestUDPZeroBytePayload (30.01s)
    udpsock_test.go:367: Read of zero byte packet failed: read udp4 127.0.0.1:63888: i/o timeout

@FiloSottile FiloSottile added the Testing label Jan 2, 2019

@silbinarywolf

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2019

Just as an FYI, I merely followed the direction of the related Github issue when doing the original CL for this and I don't have any ideas on how to resolve this at all. I'm willing to put in the time for another CL if somebody only has time to direct / review my work, however my thinking is somebody with more experience should probably explore this and cover it off.

Sorry I'm not more help!

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Jan 3, 2019

I'll send a CL to skip the test on Darwin. Since the Darwin 10.12 builder seems to be consistently passing, I assume it's Darwin 10.10 flakiness that has been fixed since then.

@gopherbot

This comment has been minimized.

Copy link

commented Jan 3, 2019

Change https://golang.org/cl/156119 mentions this issue: net: skip TestUDPZeroBytePayload on Darwin

gopherbot pushed a commit that referenced this issue Jan 3, 2019

net: skip TestUDPZeroBytePayload on Darwin
Updates #29225

Change-Id: I4c9b7a108861ce5c9ab84f7324ced3da51e7bf2a
Reviewed-on: https://go-review.googlesource.com/c/156119
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

@bradfitz bradfitz modified the milestones: Go1.12, Unplanned Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.