New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: ensure that pseudo-versions for post-v1 commits on the master branch use v1 pseudo-versions #29262

Open
hyangah opened this Issue Dec 14, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@hyangah
Copy link
Contributor

hyangah commented Dec 14, 2018

Go version:

go version devel +976bab6003 Fri Dec 14 09:10:02 2018 +0000 darwin/amd64

rsc.io/quote's latest released version is v1.5.2.
But go chooses v0.0.0-... as the pseudo version selected when using the master branch.

> go list -m -versions -json rsc.io/quote@master
go: finding rsc.io/quote master
{
	"Path": "rsc.io/quote",
	"Version": "v0.0.0-20180710144737-5d9f230bcfba",
	"Versions": [
		"v1.0.0",
		"v1.1.0",
		"v1.2.0",
		"v1.2.1",
		"v1.3.0",
		"v1.4.0",
		"v1.5.0",
		"v1.5.1",
		"v1.5.2",
		"v1.5.3-pre1"
	],
	"Time": "2018-07-10T14:47:37Z",
	"Dir": "/Users/hakim/go/pkg/mod/rsc.io/quote@v0.0.0-20180710144737-5d9f230bcfba",
	"GoMod": "/Users/hakim/go/pkg/mod/cache/download/rsc.io/quote/@v/v0.0.0-20180710144737-5d9f230bcfba.mod"
}

Possibly related to #27171 but needs investigation.

@bcmills

@hyangah hyangah added the modules label Dec 14, 2018

@bcmills bcmills added this to the Go1.12 milestone Dec 14, 2018

@bcmills bcmills self-assigned this Dec 14, 2018

@bcmills bcmills modified the milestones: Go1.12, Go1.13 Jan 17, 2019

@bcmills bcmills added the Testing label Jan 17, 2019

@bcmills

This comment has been minimized.

Copy link
Member

bcmills commented Jan 17, 2019

Dup of #27171, but we should make sure the tests cover this case.

@bcmills bcmills changed the title cmd/go: pseudo version chosen when using commit hash or branch prefers v0 even when v1 module is available. cmd/go: ensure that pseudo-versions for post-v1 commits on the master branch use v1 pseudo-versions Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment