Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: disable openbsd-amd64-64 and freebsd-amd64-12_0 on release-branch.go1.10 #29265

FiloSottile opened this issue Dec 14, 2018 · 3 comments
Builders FrozenDueToAge NeedsFix


Copy link

@FiloSottile FiloSottile commented Dec 14, 2018

Those builders are too new for Go 1.10, and they always fail the TryBots.

Failed on openbsd-amd64-64:
Failed on freebsd-amd64-12_0:


/cc @bradfitz @dmitshur

@FiloSottile FiloSottile added the NeedsFix label Dec 14, 2018
@gopherbot gopherbot added this to the Unreleased milestone Dec 14, 2018
@gopherbot gopherbot added the Builders label Dec 14, 2018
Copy link

@bradfitz bradfitz commented Dec 14, 2018

IIRC we have all the hooks now in dashboard/builders.go to do this easily.

I'll let @dmitshur handle this one.

Copy link

@gopherbot gopherbot commented Dec 21, 2018

Change mentions this issue: dashboard, cmd/coordinator, maintner/maintnerd: add support for BuildConfig.MinimumGoVersion field

Copy link

@dmitshur dmitshur commented Jan 25, 2019

I've deployed the fix (CL 155463) and confirmed that it works.

For example, see:

That's a CL into the main Go repo on the release-branch.go1.10 branch, before the fix was deployed. 2 of the trybots failed: openbsd-amd64-64 and freebsd-amd64-12_0. Then, see:

It's the result of re-running trybots on the same CL after deploying the fix. The 2 builders that require Go 1.11+ were excluded and trybots passed.

For other trybot runs where the Go version is 1.11+, those 2 builders are still included, as expected.

@golang golang locked and limited conversation to collaborators Jan 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Builders FrozenDueToAge NeedsFix
None yet

No branches or pull requests

4 participants