New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: disable openbsd-amd64-64 and freebsd-amd64-12_0 on release-branch.go1.10 #29265

Closed
FiloSottile opened this Issue Dec 14, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@FiloSottile
Copy link
Member

FiloSottile commented Dec 14, 2018

Those builders are too new for Go 1.10, and they always fail the TryBots.

Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/74878a24/openbsd-amd64-64_3fe0d458.log
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/74878a24/freebsd-amd64-12_0_5ecb9125.log

Source: https://go-review.googlesource.com/c/go/+/151343.

/cc @bradfitz @dmitshur

@gopherbot gopherbot added this to the Unreleased milestone Dec 14, 2018

@gopherbot gopherbot added the Builders label Dec 14, 2018

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Dec 14, 2018

IIRC we have all the hooks now in dashboard/builders.go to do this easily.

I'll let @dmitshur handle this one.

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Dec 21, 2018

Change https://golang.org/cl/155463 mentions this issue: dashboard, cmd/coordinator, maintner/maintnerd: add support for BuildConfig.MinimumGoVersion field

@dmitshur

This comment has been minimized.

Copy link
Member

dmitshur commented Jan 25, 2019

I've deployed the fix (CL 155463) and confirmed that it works.

For example, see:

https://go-review.googlesource.com/c/go/+/159478/3#message-e8ce116ba7c9213e734f972e5ab033c53ab31769

That's a CL into the main Go repo on the release-branch.go1.10 branch, before the fix was deployed. 2 of the trybots failed: openbsd-amd64-64 and freebsd-amd64-12_0. Then, see:

https://go-review.googlesource.com/c/go/+/159478/3#message-621e6e4793e669e737d7356e2d6e6ff2c515da81

It's the result of re-running trybots on the same CL after deploying the fix. The 2 builders that require Go 1.11+ were excluded and trybots passed.

For other trybot runs where the Go version is 1.11+, those 2 builders are still included, as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment