Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
doc: document that developers working in the go repo should run 'go test' #29266
For a lot of folks (like me!), the name
(Or perhaps the
These names are baked into people's fingers and shell scripts. I am strongly opposed to renaming them or changing their meanings. Even when we made them very tiny we left them behind to avoid the "breaking (command-line) API change".
And all.bash time is something we try very hard to keep small. It makes a big difference whether it's 3 minutes or 10 minutes. The exhaustive regexp tests for example need not run in all.bash.
I'm sorry that all.bash sounded like it was "absolutely all tests in the world". all means make+run.
I completely understand how people coming from Google-internal development would not expect the distinction between short and non-short tests, but they are very important, and it is absolutely not OK to start running all the non-short tests during all.bash.
We do need to make a few things clearer in docs:
I was surprised that I can't find the second bullet somewhere in https://golang.org/doc/contribute.html. It should be there at least.
Let's use this bug to document better how to run tests.
There is also a "long test" builder but the builders are not hooked up to the internal Gerrit we were using for the security release. Maybe they should be.