New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: close-cherry-pick pass too aggressive #29270

Closed
bradfitz opened this Issue Dec 14, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@bradfitz
Copy link
Member

bradfitz commented Dec 14, 2018

Seen on #28673, the gopherbot close-cherry-pick pass is too aggressive:

2018/12/14 20:05:49 got corpus update after 6.071844875s
close-cherry-pick
        https://golang.org/issue/28673  x/net/http2: Transport is leaking streams on broken Body [1.11 backport]

/cc @FiloSottile @dmitshur

@bradfitz bradfitz added the NeedsFix label Dec 14, 2018

@gopherbot gopherbot added this to the Unreleased milestone Dec 14, 2018

@gopherbot gopherbot added the Builders label Dec 14, 2018

@dmitshur

This comment has been minimized.

Copy link
Member

dmitshur commented Dec 14, 2018

I think it's missing a gi.HasEvent("reopened") check, to make it not fight humans who might've re-opened the issue. Of course, it will still fight one time (due to #21312), but no more. Will send a CL.

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Dec 14, 2018

Change https://golang.org/cl/154337 mentions this issue: cmd/gopherbot: don't consider reopened issues in close-cherry-pick task

@dmitshur

This comment has been minimized.

Copy link
Member

dmitshur commented Jan 7, 2019

I've redeployed gopherbot with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment