Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.11.4 mod checksum errors #29278

Closed
nictuku opened this Issue Dec 15, 2018 · 11 comments

Comments

Projects
None yet
7 participants
@nictuku
Copy link
Contributor

nictuku commented Dec 15, 2018

$ go version
go version go1.11.4 linux/amd64

$ go get ./...

or

$ go mod download
go: verifying gotest.tools@v2.2.0+incompatible: checksum mismatch
downloaded: h1:VsBPFP1AI068pPrMxtb/S8Zkgf9xEmTLJjfM+P5UIEo=
go.sum: h1:y0IMTfclpMdsdIbr6uwmJn5/WZ7vFuObxDMdrylFM3A=

Switch to Go 1.11.3

Nuke $GOPATH/pkg/mod/cache

Repeat go get ./... or go mod download, and it works.

I'm creating a simple repo with repro steps now.

@nictuku

This comment has been minimized.

Copy link
Contributor Author

nictuku commented Dec 15, 2018

Perhaps this was because the checksums created by 1.11.3 were the "wrong" ones? So nuking the cache is probably fine?

@dotwaffle

This comment has been minimized.

Copy link

dotwaffle commented Dec 15, 2018

No, definitely not 1.11.3, my checksum was made back in August and is broken as of 1.11.4, whereas it worked with 1.11 thru 1.11.3 without showing errors:

go: verifying github.com/grpc-ecosystem/go-grpc-middleware@v1.0.0: checksum mismatch
    downloaded: h1:Iju5GlWwrvL6UBg4zJJt3btmonfrMlCDdsejg4CZE7c=
    go.sum:     h1:BWIsLfhgKhV5g/oF34aRjniBHLTZe5DNekSjbAjIS6c=
@agnivade

This comment has been minimized.

Copy link
Member

agnivade commented Dec 15, 2018

@bcmills

This comment has been minimized.

Copy link
Member

bcmills commented Dec 15, 2018

Yes, pre-1.11.4, modules containing symlinks were constructed erroneously. 1.11.4 correctly omits those symlinks, which may change the sums for a few (hopefully isolated) modules.

@bcmills

This comment has been minimized.

Copy link
Member

bcmills commented Dec 15, 2018

See #27093.

@nictuku

This comment has been minimized.

Copy link
Contributor Author

nictuku commented Dec 15, 2018

It sounds like we can close this issue. It's an inconvenient but ultimately benign error caused by previous versions.

It can be worked around by manually updating (or simply removing) the appropriate lines from go.sum.

@thepudds

This comment has been minimized.

Copy link

thepudds commented Dec 15, 2018

Note: if you have a copy of a module with symlinks in your module cache, you likely will need to run go clean -modcache in order to get 1.11.4 to generate the new (corrected) checksum. (e.g., see #29282)

fsouza added a commit to nytimes/video-captions-api that referenced this issue Dec 18, 2018

fsouza added a commit to nytimes/video-transcoding-api that referenced this issue Dec 18, 2018

Tidy go.mod and update go.sum
Should fix the build (broken by go.sum, see golang/go#29278).

markpeek added a commit to vmware/terraform-provider-vra7 that referenced this issue Feb 8, 2019

Add requirement for go 1.11.4 or above
The "go mod" changes required 1.11 or above but due to a bug
the checksum file could be incorrect for releases before 1.11.4.
Make this requirement more explicit in the README.
Reference: golang/go#29278

Signed-off-by: Mark Peek <markpeek@vmware.com>

markpeek added a commit to vmware/terraform-provider-vra7 that referenced this issue Feb 8, 2019

Add requirement for go 1.11.4 or above (#122)
The "go mod" changes required 1.11 or above but due to a bug
the checksum file could be incorrect for releases before 1.11.4.
Make this requirement more explicit in the README.
Reference: golang/go#29278

Signed-off-by: Mark Peek <markpeek@vmware.com>

lstoll added a commit to lstoll/dex that referenced this issue Feb 9, 2019

Update modules for go 1.11.4+
Go 1.11.3 changed how checksums are created in some cases, which caused
failures building via modules. (ref golang/go#29278)

Update the checksums for the failing modules.

To catch this is the future, a modules build was added to the build matrix. I
also noted that we were pinning the `.0` patchlevel of each go version which
wouldn't have picked this up, updated it to build with the latest patch
release.

lstoll added a commit to lstoll/dex that referenced this issue Feb 9, 2019

Update modules for go 1.11.4+
Go 1.11.3 changed how checksums are created in some cases, which caused
failures building via modules. (ref golang/go#29278)

Update the checksums for the failing modules.

To catch this is the future, a modules build was added to the build matrix. I
also noted that we were pinning the `.0` patchlevel of each go version which
wouldn't have picked this up, updated it to build with the latest patch
release.

rarkins added a commit to renovatebot/docker-go that referenced this issue Feb 14, 2019

@just1689 just1689 referenced this issue Feb 18, 2019

Merged

Various #2

@jniesen jniesen referenced this issue Feb 20, 2019

Open

Go mod #46

kbudde added a commit to kbudde/rabbitmq_exporter that referenced this issue Mar 4, 2019

kbudde added a commit to kbudde/rabbitmq_exporter that referenced this issue Mar 4, 2019

niklas88 added a commit to ad-freiburg/wharfer that referenced this issue Mar 18, 2019

Force correct checksum
This is likely caused by this Go bug:
golang/go#29278

daixiang0 added a commit to daixiang0/thanos that referenced this issue Mar 22, 2019

Add help when make failed
refer to [comment](golang/go#29278 (comment))

Signed-off-by: Xiang Dai <764524258@qq.com>

bwplotka added a commit to improbable-eng/thanos that referenced this issue Mar 22, 2019

Add help when make failed (#958)
refer to [comment](golang/go#29278 (comment))

Signed-off-by: Xiang Dai <764524258@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.