Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: get fails to get github.com/mibk/g.. #29302

Closed
nkovacs opened this issue Dec 17, 2018 · 6 comments
Closed

cmd/go: get fails to get github.com/mibk/g.. #29302

nkovacs opened this issue Dec 17, 2018 · 6 comments

Comments

@nkovacs
Copy link

@nkovacs nkovacs commented Dec 17, 2018

What version of Go are you using (go version)?

$ go version
go version go1.11.4 linux/amd64

Does this issue reproduce with the latest release?

Yes. This is a side effect of the security fix in 1.11.3, #29230.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/nkovacs/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/nkovacs/progs/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build928219988=/tmp/go-build -gno-record-gcc-switches"

What did you do?

go get -u github.com/mibk/g..

What did you expect to see?

g.. successfully installed.

What did you see instead?

package github.com/mibk/g..: github.com/mibk/g..: invalid import path: malformed import path "github.com/mibk/g..": double dot

@agnivade

This comment has been minimized.

Copy link
Contributor

@agnivade agnivade commented Dec 17, 2018

The fix was made in 1.11.4 (#29241), which you seem to have. Are you certain there are no conflicting versions of Go installed ?

@nkovacs

This comment has been minimized.

Copy link
Author

@nkovacs nkovacs commented Dec 17, 2018

I believe the fix in 1.11.4 only fixed go get github.com/user/repo/...

@oiooj oiooj added the modules label Dec 17, 2018
@shuLhan

This comment has been minimized.

Copy link
Contributor

@shuLhan shuLhan commented Dec 17, 2018

@nkovacs

I believe "g.." is violating package name [1]. Even if its work with previous Go version, it should not.

[1] https://golang.org/ref/spec#PackageName

@nkovacs

This comment has been minimized.

Copy link
Author

@nkovacs nkovacs commented Dec 17, 2018

g.. is not the package name though. It's just the repo name. The package name is main.

@agnivade

This comment has been minimized.

Copy link
Contributor

@agnivade agnivade commented Dec 17, 2018

I see. The repo name itself is g...

/cc @bcmills

@agnivade agnivade changed the title go get fails to get github.com/mibk/g.. cmd/go: get fails to get github.com/mibk/g.. Dec 17, 2018
@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Dec 17, 2018

Sorry, but there are too many ways to play games with leading and trailing dots to produce name collisions on various filesystems, and this particular example appears to be deprecated since Go 1.9 anyway.

@bcmills bcmills closed this Dec 17, 2018
@golang golang locked and limited conversation to collaborators Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.