Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile, cmd/link: relocation target go.builtin.error.Error not defined [1.11 backport] #29307

Closed
gopherbot opened this issue Dec 17, 2018 · 2 comments

Comments

Assignees
No one assigned
Labels
CherryPickCandidate
Projects
None yet
Milestone
  Go1.11.6
2 participants
@gopherbot @julieqiu
@gopherbot
Copy link

commented Dec 17, 2018

@bradfitz requested issue #29304 to be considered for backport to the next 1.11 minor release.

@gopherbot, please backport to Go 1.11.

@gopherbot gopherbot added the CherryPickCandidate label Dec 17, 2018

@gopherbot gopherbot referenced this issue Dec 17, 2018

Closed

cmd/compile, cmd/link: relocation target go.builtin.error.Error not defined #29304

@gopherbot gopherbot added this to the Go1.11.5 milestone Dec 17, 2018

@gopherbot

This comment has been minimized.

Sign in to view
Copy link
Author

commented Dec 17, 2018

Change https://golang.org/cl/154579 mentions this issue: [release-branch.go1.11] cmd/compile: generate interface method expression wrapper for error.Error
@gopherbot

This comment has been minimized.

Sign in to view
Copy link
Author

commented Dec 17, 2018

Closed by merging a171e15 to release-branch.go1.11.

@gopherbot gopherbot closed this Dec 17, 2018

gopherbot pushed a commit that referenced this issue Dec 17, 2018

@griesemer @bradfitz
[release-branch.go1.11] cmd/compile: generate interface method expres… 
…sion wrapper for error.Error

A prior optimization (https://golang.org/cl/106175) removed the
generation of unnecessary method expression wrappers, but also
eliminated the generation of the wrapper for error.Error which
was still required.

Special-case error type in the optimization.

Fixes #29307

Change-Id: I54c8afc88a2c6d1906afa2d09c68a0a3f3e2f1e3
Reviewed-on: https://go-review.googlesource.com/c/154578
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit a1aafd8)
Reviewed-on: https://go-review.googlesource.com/c/154579
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
Loading status checks…
a171e15

@julieqiu julieqiu modified the milestones: Go1.11.5, Go1.11.6 Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.