Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: split cookie header as recommended by spec #29386

Open
rs opened this Issue Dec 21, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@rs
Copy link
Contributor

commented Dec 21, 2018

As per 8.1.2.5, To allow for better compression efficiency, the Cookie header field MAY be split into separate header fields, each with one or more cookie-pairs.

After some tests, it does positively impact compression rate and reduces the eviction rate on the dynamic table (flavor may vary depending traffic patterns).

@gopherbot

This comment has been minimized.

Copy link

commented Dec 21, 2018

Change https://golang.org/cl/155657 mentions this issue: x/net/http2: split cookie pair into separate hpack header fields

@katiehockman katiehockman changed the title x/net/http2: split cookie header as recommended by spec net/http2: split cookie header as recommended by spec Jan 2, 2019

@katiehockman

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2019

/cc @bradfitz

@katiehockman katiehockman added this to the Go1.13 milestone Jan 2, 2019

@rs rs changed the title net/http2: split cookie header as recommended by spec x/net/http2: split cookie header as recommended by spec Jan 2, 2019

@bradfitz

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

SGTM.

@bradfitz bradfitz added the NeedsFix label Jan 2, 2019

@gopherbot gopherbot removed the NeedsDecision label Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.