Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestScript/build_runtime_gcflags failing on longtest builder #29395

Closed
ALTree opened this issue Dec 22, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@ALTree
Copy link
Member

commented Dec 22, 2018

The TestScript harness is currently broken, causing a failure in the cmd/go test suite on the longtest builder. A log:

https://build.golang.org/log/13f2837122b3a012cc7d46fe08e0214ca5ee61fb

The failures started at 0005515 (cmd/go: fix -n output in runtime/internal/atomic).

cc @jayconrod

@ALTree ALTree added this to the Go1.12 milestone Dec 22, 2018

@mvdan

This comment has been minimized.

Copy link
Member

commented Dec 23, 2018

That's when the test script was added. Weirdly enough, the test script passes on my machine.

Also, I think the comment on the test script is wrong. It says "See golang.org/issue/26092.", but that issue seems completely unrelated to the build flags bug.

@jayconrod jayconrod self-assigned this Jan 2, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Jan 3, 2019

Change https://golang.org/cl/156237 mentions this issue: cmd/go: fix failure in TestScript/build_runtime_gcflags

@jayconrod

This comment has been minimized.

Copy link
Contributor

commented Jan 3, 2019

This was a misconception on my part. I assumed the tests were using separate caches. This issue could be reproduced by running go build -gcflags=all=-l std before running the test.

The test will now creates its own cache directory.

(Also, fixed the issue URL. Thanks for pointing that out.)

@gopherbot gopherbot closed this in 9a7278a Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.