Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upnet/http: add digest access authentication to Transport #29409
Comments
This comment has been minimized.
This comment has been minimized.
Thank you @Baozisoftware for filing this request and welcome to the Go project! I'll page some experts @bradfitz @FiloSottile @agl. |
This comment has been minimized.
This comment has been minimized.
I'm not opposed. I would use this functionality myself. (I have code in a number of places to do this by hand, which gets tedious.) Please start by proposing a concrete API. Once we like the API we can then move on to reviewing code. |
This comment has been minimized.
This comment has been minimized.
The best third party library I've found is https://github.com/bobziuchkovski/digest |
This comment has been minimized.
This comment has been minimized.
Hi, as I've exposed in a telegraf issue I'll like to also suggest the support for Digest authentication in http. Let me quote:
and
Take in mind that many companies use Digest auth by default instead of basic auth because of the added security features. Even Digest is not perfect or the best, it's at least a step forward to basic auth. Thanks ! |
I tried to add Digest access authentication support in http.Transport today. currently it is available for proxy servers. (compatible with basic auth,but not tested.)
I hope the official can integrate it. After all, this is a base library.
Reference: https://github.com/delphinus/go-digest-request
Mainly modified:
Transport.roundTrip
Transport.dialConn