Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: textflag.h contains spurious equals in REFLECTMETHOD macro #29487

Closed
mmcloughlin opened this issue Jan 1, 2019 · 1 comment
Closed

runtime: textflag.h contains spurious equals in REFLECTMETHOD macro #29487

mmcloughlin opened this issue Jan 1, 2019 · 1 comment
Labels
FrozenDueToAge

Comments

@mmcloughlin
Copy link
Contributor

@mmcloughlin mmcloughlin commented Jan 1, 2019

I believe there is a copy-paste error in the textflag.h REFLECTMETHOD macro:

go/src/runtime/textflag.h

Lines 33 to 34 in ed78c90

// Function can call reflect.Type.Method or reflect.Type.MethodByName.
#define REFLECTMETHOD = 1024

@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented Jan 1, 2019

Change https://golang.org/cl/155927 mentions this issue: runtime: fix REFLECTMETHOD macro
@mmcloughlin mmcloughlin changed the title src/runtime: textflag.h contains spurious equals in REFLECTMETHOD macro runtime: textflag.h contains spurious equals in REFLECTMETHOD macro Jan 1, 2019
@gopherbot gopherbot closed this in 204a8f5 Jan 1, 2019
@golang golang locked and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@mmcloughlin @gopherbot
You can’t perform that action at this time.