Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: implement replacement for Waitmsg #2949

Closed
rsc opened this issue Feb 9, 2012 · 5 comments
Closed

os: implement replacement for Waitmsg #2949

rsc opened this issue Feb 9, 2012 · 5 comments
Assignees
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Feb 9, 2012

Waitmsg is hopelessly unportable.
Define a new struct or interface.

Replace wait arguments (WUNTRACED ...) too.
@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Feb 10, 2012

Comment 1:

Dup of issue #2823.
Will close that one.
@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Feb 10, 2012

Comment 2:

Issue #2823 has been merged into this issue.

@robpike

This comment has been minimized.

Copy link
Contributor

@robpike robpike commented Feb 17, 2012

Comment 3:

Text by the primary fitz from closed 2383:
Problems with the bits in *os.Process Wait(options int)
1) they're non-portable
2) they're a mix of syscall bit numberspace and Go-assigned numbers (1 << 20 for
os.WRUSAGE)
We should clean this up somehow:
a) remove the options parameter to Wait
b) keep the options parameter, but document the bits as all Go-defined portable bits
(like FileMode)
c) document that they're all syscall bits and pass them along, but don't provide alias.
force callers to use syscall.WNOHANG, etc.  that leaves WRUSAGE, but we could just
always return that, and remove WRUSAGE.
@dsymonds

This comment has been minimized.

Copy link
Member

@dsymonds dsymonds commented Feb 19, 2012

Comment 4:

Owner changed to @robpike.

Status changed to Started.

@robpike

This comment has been minimized.

Copy link
Contributor

@robpike robpike commented Feb 21, 2012

Comment 5:

Fixed by http://golang.org/cl/5673077/.

Status changed to Fixed.

@rsc rsc added fixed labels Feb 21, 2012
@rsc rsc added this to the Go1 milestone Apr 10, 2015
@rsc rsc removed priority-go1 labels Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.