Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: GDB tests fail on freebsd/arm builder #29508

Open
bradfitz opened this Issue Jan 2, 2019 · 5 comments

Comments

Projects
None yet
3 participants
@bradfitz
Copy link
Member

commented Jan 2, 2019

From #28679 (comment) ...

This is still failing freebsd-arm-paulzhol builds.
Latest failure: https://build.golang.org/log/d9278491818714d74a9190557d6107f737d48612

Is it feasible to disable this test, as @bradfitz suggested earlier? Or is there something else that can be tried?

Disabling for now.

/cc @paulzhol

@gopherbot

This comment has been minimized.

Copy link

commented Jan 2, 2019

Change https://golang.org/cl/155932 mentions this issue: runtime: disable GDB tests on freebsd/arm for now

gopherbot pushed a commit that referenced this issue Jan 2, 2019

runtime: disable GDB tests on freebsd/arm for now
Updates #29508
Updates #28679

Change-Id: I19bc9f88aeb2b1f3e69856173a00c5a4d5ed3613
Reviewed-on: https://go-review.googlesource.com/c/155932
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
@paulzhol

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

I've booted the older 11.2 image and ran the test:

[paulzhol@arm-virt /tmp/go/src/runtime]$ ../../bin/go test -v -run "GdbPython$"                                    
=== RUN   TestGdbPython                                                                                            
=== PAUSE TestGdbPython                                                                                            
=== CONT  TestGdbPython                                                                                            
--- SKIP: TestGdbPython (0.25s)                                                                                    
    runtime-gdb_test.go:68: skipping: gdb version 6.1 too old                                                      
PASS                                                                                                               
ok      runtime 0.373s

That is the in-tree gdb, it's really old.

[paulzhol@arm-virt /tmp/go/src/runtime]$ gdb                                                                       
GNU gdb 6.1.1 [FreeBSD]                                                                                            
Copyright 2004 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "armv6-marcel-freebsd".

It seems it was finally retired from FreeBSD 12 as intended.
If I modify the test to use the ports collection gdb81, the test fails the same as with the GDB 8.2 builder log.

This raises several concerns:

  • All our amd64 builders except the FreeBSD 12 one have an ancient GDB, so they have always skipped the test.
  • The FreeBSD 12 image needs to be updated to install a gdb from the ports collection as it has none at all.
  • This will cause the test to fail, so it needs to be disabled on all GOARCHes, not just arm.
@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Jan 7, 2019

Send the CL to always skip the tests on all GOARCH values for GOOS freebsd first, and then we can update the image to include a newer gdb and work on fixing the issue (and remove the t.Skip)

@gopherbot

This comment has been minimized.

Copy link

commented Jan 7, 2019

Change https://golang.org/cl/156717 mentions this issue: runtime: disable GDB tests on freebsd on all GOARCH values

gopherbot pushed a commit that referenced this issue Jan 8, 2019

runtime: disable GDB tests on freebsd on all GOARCH values
The in-tree GDB is too old (6.1.1) on all the builders except the
FreeBSD 12.0 one, where it was removed from the base system.

Update #29508

Change-Id: Ib6091cd86440ea005f3f903549a0223a96621a6f
Reviewed-on: https://go-review.googlesource.com/c/156717
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Feb 1, 2019

Change https://golang.org/cl/160800 mentions this issue: [release-branch.go1.11] runtime: disable GDB tests on freebsd on all GOARCH values

gopherbot pushed a commit that referenced this issue Feb 1, 2019

[release-branch.go1.11] runtime: disable GDB tests on freebsd on all …
…GOARCH values

The in-tree GDB is too old (6.1.1) on all the builders except the
FreeBSD 12.0 one, where it was removed from the base system.

Update #29508

Change-Id: Ib6091cd86440ea005f3f903549a0223a96621a6f
Reviewed-on: https://go-review.googlesource.com/c/156717
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/160800
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Yuval Pavel Zholkover <paulzhol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.