Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build/cmd/coordinator: subrepo trybots testing against security branch #29510
Seen on a trybot run:
I suspect there's a bug in the fixes for #17626, or old assumptions that no longer apply now that we have a security branch.
Maybe just filter out the security branch before we find the last N=2 releases?
Or delete the security branch altogether?
We did delete them in the canonical repository (i.e., https://go.googlesource.com/go/+refs). However, it continues to show up in the GitHub mirror repository (even after a manual deletion) due to a bug in
I suspect we'll want to fix this with a quick trybot-specific workaround first, because the underlying issues in gitmirror (and/or in maintner) may take significantly longer to investigate and fix (and can be done independently afterwards).
referenced this issue
Jan 2, 2019
This is worse than I originally understood, because trybots are not just testing the security release-branches in addition to normal release-branches, but rather only the security release-branches.
It's not too bad since the security release branches are pretty representative of Go 1.11 and Go 1.10, which is the goal of #17626, but we should still fix it so that the latest release-branches get tested. I'll start looking into this soon.