Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/link: issues handling duplicate weak symbols #29563
OpenBSD -current now enables
This can also occur with retguard on OpenBSD clang as it emits similar weak symbols per compilation unit, which can then have matching names across files.
I've attempted to construct a test case for this, however it is rather challenging since it really has to be done at the compiler level. The
I suspect that if the symbols are weak and identical then they should be permitted as duplicates, however I'm not entirely sure what the correct/expected behaviour is here. For the time being I have a diff that matches weak symbols with a prefix of
This fixes cgo test issue29563 on Darwin. Updates #29563. Change-Id: If480078461247cd7c95931ae3ad4ca89736dd550 Reviewed-on: https://go-review.googlesource.com/c/go/+/170015 Run-TryBot: Cherry Zhang <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org>