New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: non-go file HTML rendering adds a leading tab, which can become visible #29568

Open
dmitshur opened this Issue Jan 4, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@dmitshur
Copy link
Member

dmitshur commented Jan 4, 2019

The CONTRIBUTORS file does not have any leading whitespace on its lines. However, when viewed at https://golang.org/CONTRIBUTORS, the generated HTML adds leading whitespace (a single tab character):

In most cases the tab character does not show visually up due to the way CSS is used to style content:

However, in some cases it becomes highly visible and distracting:

This does not affect the plain-text rendering mode of text files (e.g., https://golang.org/CONTRIBUTORS?m=text), only the HTML rendering.

@dmitshur dmitshur added this to the Unplanned milestone Jan 4, 2019

@dmitshur

This comment has been minimized.

Copy link
Member

dmitshur commented Jan 4, 2019

As noted by @bradfitz, this doesn't seem to affect rendered .go files. There is no leading tab character inserted in HTML on pages like https://golang.org/src/net/http/server.go:

It does affect other text files without an extension like https://golang.org/LICENSE, https://golang.org/AUTHORS, and files with non-go extension like https://golang.org/src/make.bash.

@dmitshur dmitshur changed the title x/website: plain text file rendering adds a leading tab, which can become visible x/website: non-go file HTML rendering adds a leading tab, which can become visible Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment