Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: auto-reviewers are not applied for some GitHub CLs #29569

Open
FiloSottile opened this issue Jan 4, 2019 · 0 comments
Open

x/build/cmd/gerritbot: auto-reviewers are not applied for some GitHub CLs #29569

FiloSottile opened this issue Jan 4, 2019 · 0 comments
Labels
Builders NeedsFix help wanted
Milestone
Unreleased

Comments

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Jan 4, 2019

When a PR is created by an author that has a Gerrit account, they are added as a reviewer to their own CL. Since the CL has a reviewer, gerritbot then does not apply autoreviewers.

For example: https://go-review.googlesource.com/c/go/+/156297

Maybe the answer is to add them as CC, not as reviewers. I'm not sure why that's the current behavior, but it might be an automatic Gerrit behavior, similarly to how it adds reviewers if it detects them listed manually as Reviewed-By.

/cc @andybons
@gopherbot gopherbot added this to the Unreleased milestone Jan 4, 2019
@gopherbot gopherbot added the Builders label Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders NeedsFix help wanted
Projects
None yet
Milestone
  Unreleased
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@FiloSottile @gopherbot
You can’t perform that action at this time.