Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: add zone files to $GOROOT #2964

Closed
rsc opened this issue Feb 9, 2012 · 3 comments

Comments

Projects
None yet
3 participants
@rsc
Copy link
Contributor

commented Feb 9, 2012

If the tz files are not found in the standrd Unix places,
fall back to looking in $GOROOT.  This is for Windows
and Plan 9.

rsc will do this
@rsc

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2012

Comment 1:

This issue was closed by revision ad17a9c.

Status changed to Fixed.

@peterGo

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2012

Comment 2:

For Windows, use the Windows API and the Windows Registry, not tzdata. By design,
Windows doesn't use tzdata. Windows users update time zone data via Windows update. They
don't expect to have to update tzdata too--they have never heard of it. This introduces
a subtle and pernicious bug on Windows systems.
@rsc

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2012

Comment 3:

Thanks for your concern.  The tzdata is needed only for time.LoadLocation.
The time zone information in the kernel used for time.Local (the local
time zone), but I do not believe it can provide information about other
time zones, and it does not use the standard IANA names.
Only programs that use time.LoadLocation need to worry about the
time zone data file.  If you can implement the same functionality,
using the same location names, with the kernel API alone, then I'd
be happy to review a CL.
Russ

@rsc rsc added fixed labels Feb 19, 2012

@rsc rsc self-assigned this Feb 19, 2012

@rsc rsc added this to the Go1 milestone Apr 10, 2015

@rsc rsc removed priority-go1 labels Apr 10, 2015

@golang golang locked and limited conversation to collaborators Jun 24, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.