New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/packages: TestLoadImportsGraph is failing on s390x #29660

Closed
dmitshur opened this Issue Jan 10, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@dmitshur
Copy link
Member

dmitshur commented Jan 10, 2019

The TestLoadImportsGraph test is failing on s390x on latest x/tools commit (golang/tools@51295c7). It can be seen at https://build.golang.org.

It happens with Go on latest tip (44cf595), as well as with latest release-branch.go.1.11 (e39e43d).

--- FAIL: TestLoadImportsGraph (1.49s)
    --- FAIL: TestLoadImportsGraph/GOPATH (0.61s)
        packages_test.go:191: golang.org/fake/subdir/d.test.Srcs = [4302876da86a8aae0c1669924daa223cafca60ef49ccaa060ae37e778d18f218-d], want [0.go]
    --- FAIL: TestLoadImportsGraph/Modules (0.89s)
        packages_test.go:191: golang.org/fake/subdir/d.test.Srcs = [4302876da86a8aae0c1669924daa223cafca60ef49ccaa060ae37e778d18f218-d], want [0.go]
FAIL
FAIL	golang.org/x/tools/go/packages	20.935s

See full log at https://build.golang.org/log/dae7ea9d26e4fe76c9ccd619842295c09ce5d6e7.

There's a very good chance this is the same issue as #29445 (/cc @mvdan), but this issue is specifically about the s390x failure, which we need to fix for #11811.

@matloob

This comment has been minimized.

Copy link
Contributor

matloob commented Jan 10, 2019

I'll wait to see if @mvdan's CL fixes this once it's submitted. If not, we'll have to debug it on a s390x machine. (I might get to "hack into a mainframe"!)

@dmitshur

This comment has been minimized.

Copy link
Member

dmitshur commented Jan 16, 2019

CL 156977 has fixed the issue for s390x as well. It must've been using a custom GOCACHE all along, before all the other environments started to as well.

Thank you @mvdan and @matloob!

@dmitshur dmitshur closed this Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment