Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: encoding/json: add InputOffset to json decoder #29688

Closed
sheerun opened this issue Jan 11, 2019 · 3 comments
Closed

proposal: encoding/json: add InputOffset to json decoder #29688

sheerun opened this issue Jan 11, 2019 · 3 comments

Comments

@sheerun
Copy link

@sheerun sheerun commented Jan 11, 2019

In similar spirit to #8484

Use case: I'm trying to index entries in JSON file by their byte offset position to allow random access

I've already created PR with example implementation: #29686

@julieqiu julieqiu added the Proposal label Jan 11, 2019
@julieqiu julieqiu changed the title encoding/json: Proposal: Add InputOffset to json decoder proposal: encoding/json: add InputOffset to json decoder Jan 11, 2019
@gopherbot gopherbot added this to the Proposal milestone Jan 11, 2019
@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Jan 16, 2019

The justification in #8484 for encoding/xml seems just as compelling in encoding/json. Accepted.

(Note that we are in a release freeze and won't start reviewing new contributions until Go 1.13 work begins.)

@rsc rsc modified the milestones: Proposal, Go1.13 Jan 16, 2019
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Oct 11, 2019

Change https://golang.org/cl/200677 mentions this issue: encoding/json: add Decoder.InputOffset for offset access

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Oct 11, 2019

Change https://golang.org/cl/157519 mentions this issue: encoding/json: add Decoder.InputOffset for offset access

@gopherbot gopherbot closed this in ba108c9 Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.