Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: encoding/json: add InputOffset to json decoder #29688

Closed
sheerun opened this issue Jan 11, 2019 · 4 comments
Closed

proposal: encoding/json: add InputOffset to json decoder #29688

sheerun opened this issue Jan 11, 2019 · 4 comments
Labels
NeedsFix Proposal Proposal-Accepted help wanted
Milestone
Backlog

Comments

@sheerun
Copy link

@sheerun sheerun commented Jan 11, 2019

In similar spirit to #8484

Use case: I'm trying to index entries in JSON file by their byte offset position to allow random access

I've already created PR with example implementation: #29686
@sheerun sheerun mentioned this issue Jan 11, 2019
Closed
@julieqiu julieqiu added the Proposal label Jan 11, 2019
@julieqiu julieqiu changed the title encoding/json: Proposal: Add InputOffset to json decoder proposal: encoding/json: add InputOffset to json decoder Jan 11, 2019
@gopherbot gopherbot added this to the Proposal milestone Jan 11, 2019
@rsc
Copy link
Contributor

@rsc rsc commented Jan 16, 2019

The justification in #8484 for encoding/xml seems just as compelling in encoding/json. Accepted.

(Note that we are in a release freeze and won't start reviewing new contributions until Go 1.13 work begins.)
@rsc rsc modified the milestones: Proposal, Go1.13 Jan 16, 2019
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 11, 2019

Change https://golang.org/cl/200677 mentions this issue: encoding/json: add Decoder.InputOffset for offset access
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 11, 2019

Change https://golang.org/cl/157519 mentions this issue: encoding/json: add Decoder.InputOffset for offset access
@gopherbot gopherbot closed this in ba108c9 Oct 11, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 31, 2020

Change https://golang.org/cl/217123 mentions this issue: doc/go1.14: mention new method encoding/json.Decoder.InputOffset
gopherbot pushed a commit that referenced this issue Jan 31, 2020
@ianlancetaylor
doc/go1.14: mention new method encoding/json.Decoder.InputOffset
eadf8b2 
Updates #29688
Updates #36878

Change-Id: I230889ec3f1c183dc5adbc662a39a791c0488497
Reviewed-on: https://go-review.googlesource.com/c/go/+/217123
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@dsnet dsnet mentioned this issue Nov 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix Proposal Proposal-Accepted help wanted
Projects
None yet
Milestone
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@rsc @sheerun @andybons @ianlancetaylor @julieqiu @gopherbot
You can’t perform that action at this time.