Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestLookupGmailTXT is failing #29698

Closed
ianlancetaylor opened this issue Jan 11, 2019 · 5 comments

Comments

Assignees
No one assigned
Labels
NeedsInvestigation release-blocker
Projects
None yet
Milestone
  Go1.12
2 participants
@ianlancetaylor @gopherbot
@ianlancetaylor
Copy link
Contributor

commented Jan 11, 2019

Just seen on the trybots, e.g., https://storage.googleapis.com/go-build-log/0a03647a/linux-amd64_1b1d2882.log :

--- FAIL: TestLookupGmailTXT (0.00s)
    lookup_test.go:242: got globalsign-smime-dv=CDYX+XFHUw2wml6/Gb8+59BsH31KzUr6c1l2BPvqKX8=; want a record containing spf, google.com
    lookup_test.go:242: got globalsign-smime-dv=CDYX+XFHUw2wml6/Gb8+59BsH31KzUr6c1l2BPvqKX8=; want a record containing spf, google.com
FAIL
FAIL	 net	8.834s

Also happens when I run the test by hand. Looks like something has changed.

@ianlancetaylor ianlancetaylor added NeedsInvestigation release-blocker labels Jan 11, 2019

@ianlancetaylor ianlancetaylor added this to the Go1.12 milestone Jan 11, 2019

@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Jan 11, 2019

Change https://golang.org/cl/157638 mentions this issue: net: pass if at least one matching entry in TestLookupGmailTXT
@ianlancetaylor

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Jan 11, 2019

Presumably due to the change in the DNS entries this is now failing for earlier Go releases as well, so

@gopherbot Please open backport to 1.10 and 1.11.

This was referenced Jan 11, 2019

Closed
Closed
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Jan 11, 2019

Backport issue(s) opened: #29699 (for 1.10), #29700 (for 1.11).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@gopherbot gopherbot closed this in 7cbfa55 Jan 12, 2019

@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Jan 12, 2019

Change https://golang.org/cl/157639 mentions this issue: [release-branch.go1.11] net: pass if at least one matching entry in TestLookupGmailTXT
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Jan 12, 2019

Change https://golang.org/cl/157640 mentions this issue: [release-branch.go1.10] net: pass if at least one matching entry in TestLookupGmailTXT

gopherbot pushed a commit that referenced this issue Jan 14, 2019

@ianlancetaylor
[release-branch.go1.11] net: pass if at least one matching entry in T… 
…estLookupGmailTXT

Updates #29698
Fixes #29700

Change-Id: I0531c0a274b120af8871aa2f5975744ff6c912a3
Reviewed-on: https://go-review.googlesource.com/c/157638
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 7cbfa55)
Reviewed-on: https://go-review.googlesource.com/c/157639
cbf9140

gopherbot pushed a commit that referenced this issue Jan 14, 2019

@ianlancetaylor
[release-branch.go1.10] net: pass if at least one matching entry in T… 
…estLookupGmailTXT

Updates #29698
Fixes #29699

Change-Id: I0531c0a274b120af8871aa2f5975744ff6c912a3
Reviewed-on: https://go-review.googlesource.com/c/157638
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 7cbfa55)
Reviewed-on: https://go-review.googlesource.com/c/157640
c731a7d

gopherbot pushed a commit that referenced this issue Jan 23, 2019

@ianlancetaylor @FiloSottile
[release-branch.go1.11-security] net: pass if at least one matching e… 
…ntry in TestLookupGmailTXT

Fixes #29698

Change-Id: I0531c0a274b120af8871aa2f5975744ff6c912a3
Reviewed-on: https://go-review.googlesource.com/c/157638
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-on: https://team-review.git.corp.google.com/c/401203
Reviewed-by: Filippo Valsorda <valsorda@google.com>
daef79d

gopherbot pushed a commit that referenced this issue Jan 23, 2019

@ianlancetaylor @FiloSottile
[release-branch.go1.10-security] net: pass if at least one matching e… 
…ntry in TestLookupGmailTXT

Fixes #29698

Change-Id: I0531c0a274b120af8871aa2f5975744ff6c912a3
Reviewed-on: https://go-review.googlesource.com/c/157638
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-on: https://team-review.git.corp.google.com/c/401204
Reviewed-by: Filippo Valsorda <valsorda@google.com>
ed3af1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.