Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestLookupGmailTXT is failing [1.10 backport] #29699

Closed
gopherbot opened this issue Jan 11, 2019 · 2 comments

Comments

Assignees
No one assigned
Labels
CherryPickCandidate
Projects
None yet
Milestone
  Go1.10.9
2 participants
@gopherbot @julieqiu
@gopherbot
Copy link

commented Jan 11, 2019

@ianlancetaylor requested issue #29698 to be considered for backport to the next 1.10 minor release.

Presumably due to the change in the DNS entries this is now failing for earlier Go releases as well, so

@gopherbot Please open backport to 1.10 and 1.11.

@gopherbot gopherbot added the CherryPickCandidate label Jan 11, 2019

@gopherbot gopherbot referenced this issue Jan 11, 2019

Closed

net: TestLookupGmailTXT is failing #29698

@gopherbot gopherbot added this to the Go1.10.8 milestone Jan 11, 2019

@gopherbot

This comment has been minimized.

Sign in to view
Copy link
Author

commented Jan 12, 2019

Change https://golang.org/cl/157640 mentions this issue: [release-branch.go1.10] net: pass if at least one matching entry in TestLookupGmailTXT

gopherbot pushed a commit that referenced this issue Jan 14, 2019

@ianlancetaylor
[release-branch.go1.10] net: pass if at least one matching entry in T… 
…estLookupGmailTXT

Updates #29698
Fixes #29699

Change-Id: I0531c0a274b120af8871aa2f5975744ff6c912a3
Reviewed-on: https://go-review.googlesource.com/c/157638
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 7cbfa55)
Reviewed-on: https://go-review.googlesource.com/c/157640
c731a7d
@gopherbot

This comment has been minimized.

Sign in to view
Copy link
Author

commented Jan 14, 2019

Closed by merging c731a7d to release-branch.go1.10.

@gopherbot gopherbot closed this Jan 14, 2019

@julieqiu julieqiu modified the milestones: Go1.10.8, Go1.10.9 Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.