Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestLookupGmailTXT failing on Plan 9 #29722

Open
0intro opened this issue Jan 13, 2019 · 3 comments
Open

net: TestLookupGmailTXT failing on Plan 9 #29722

0intro opened this issue Jan 13, 2019 · 3 comments
Assignees
@0intro
Milestone
Unplanned

Comments

@0intro
Copy link
Member

@0intro 0intro commented Jan 13, 2019

Since CL 157638, TestLookupGmailTXT is failing on Plan 9.

--- FAIL: TestLookupGmailTXT (0.01s)
    lookup_test.go:248: got [globalsign-smime-dv=CDYX+XFHUw2wml6/Gb8+59BsH31KzUr6c1l2BPvqKX8=]; want a record containing spf, google.com
    lookup_test.go:248: got [globalsign-smime-dv=CDYX+XFHUw2wml6/Gb8+59BsH31KzUr6c1l2BPvqKX8=]; want a record containing spf, google.com
FAIL
FAIL	net	28.014s

See https://build.golang.org/log/10777f5ddff9d26836ac135c8c451166efa529ca
@0intro 0intro added this to the Go1.12 milestone Jan 13, 2019
@0intro 0intro self-assigned this Jan 13, 2019
@0intro
Copy link
Member Author

@0intro 0intro commented Jan 13, 2019

This is related to issue #22857.
@0intro
Copy link
Member Author

@0intro 0intro commented Jan 13, 2019 •
edited

The Plan 9 DNS resolver (ndb/dns) only returns a single TXT record, so the TXT request on gmail.com returns either the SPF or the S/MIME record depending on the machine on which ndb/dns is run.

cpu% ndb/dnsquery
> gmail.com txt
gmail.com txt	v=spf1 redirect=_spf.google.com

cpu% ndb/dnsquery
> gmail.com txt
gmail.com txt globalsign-smime-dv=CDYX+XFHUw2wml6/Gb8+59BsH31KzUr6c1l2BPvqKX8=
@gopherbot
Copy link

@gopherbot gopherbot commented Jan 13, 2019

Change https://golang.org/cl/157737 mentions this issue: net: skip TestLookupGmailTXT on Plan 9
gopherbot pushed a commit that referenced this issue Jan 14, 2019
@0intro
net: skip TestLookupGmailTXT on Plan 9
4e8aaf6 
CL 157638 updated TestLookupGmailTXT. However, this
test is failing on Plan 9, because the DNS resolver
(ndb/dns) only returns a single TXT record.

Updates #29722.

Change-Id: I01cd94e6167902361c3f5d615868f6f763a31fb1
Reviewed-on: https://go-review.googlesource.com/c/157737
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@bradfitz bradfitz modified the milestones: Go1.12, Unplanned Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0intro 0intro

Labels
None yet
Projects
None yet
Milestone
Unplanned
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@bradfitz @0intro @gopherbot
You can’t perform that action at this time.