Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/godoc: search bar is visible without -index option #29741

Open
nhooyr opened this issue Jan 15, 2019 · 2 comments
Open

x/tools/cmd/godoc: search bar is visible without -index option #29741

nhooyr opened this issue Jan 15, 2019 · 2 comments
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Jan 15, 2019

See https://github.com/golang/tools/blob/bf090417da8b6150dcfe96795325f5aa78fff718/cmd/godoc/doc.go#L26

Running latest godoc without -index shows:

screen shot 2019-01-14 at 10 19 02 pm

@agnivade
Copy link
Contributor

Yes, I have tried to fix this long back. But the css screws up every time. Good to have an open issue.

Could you please fill up the issue template along with the commit hash of godoc that you are running so that it is easy for anyone to pick this up ? Thanks.

@agnivade agnivade changed the title godoc: search bar is visible without -index option x/tools/cmd/godoc: search bar is visible without -index option Jan 15, 2019
@gopherbot gopherbot added this to the Unreleased milestone Jan 15, 2019
@agnivade agnivade added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Jan 15, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/169338 mentions this issue: godoc: Hide search bar when "-index" flag is specified.

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants