Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: don't negotiate RSA-PSS algorithms that are too big for our key #29793

Closed
FiloSottile opened this issue Jan 17, 2019 · 2 comments
Closed

crypto/tls: don't negotiate RSA-PSS algorithms that are too big for our key #29793

FiloSottile opened this issue Jan 17, 2019 · 2 comments
Assignees
@FiloSottile
Labels
NeedsFix
Milestone
Go1.14

Comments

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Jan 17, 2019

A (weird, non-Go) client that prefers PSSWithSHA512 (minimum key size 1040 bits) but supports PSSWithSHA256 (minimum key size 528 bits) would fail to connect to a Go server with a certificate with a 1024 bit key.

We should refuse to negotiate parameters that we already know are not supported by the certificate key.

See #29779 (comment)
@FiloSottile FiloSottile added this to the Go1.13 milestone Jan 17, 2019
@FiloSottile FiloSottile self-assigned this Jan 17, 2019
@FiloSottile FiloSottile mentioned this issue Jan 17, 2019
Closed
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@FiloSottile

This comment has been minimized.

Sign in to view
Copy link
Member Author

@FiloSottile FiloSottile commented Jul 22, 2019 •
edited

This makes sense to tackle along with #32426 and #28660, as well as with updating the certificate selection logic.
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@FiloSottile FiloSottile modified the milestones: Backlog, Go1.14 Oct 23, 2019
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented Nov 4, 2019

Change https://golang.org/cl/205177 mentions this issue: crypto/tls: take key size into account in signature algorithm selection
@gopherbot gopherbot closed this in c2edcf4 Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FiloSottile FiloSottile

Labels
NeedsFix
Projects
None yet
Milestone
  Go1.14
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@FiloSottile @gopherbot @rsc @andybons
You can’t perform that action at this time.