Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upcrypto/tls: don't negotiate RSA-PSS algorithms that are too big for our key #29793
Comments
FiloSottile
added
NeedsFix
release-blocker
labels
Jan 17, 2019
FiloSottile
added this to the Go1.13 milestone
Jan 17, 2019
FiloSottile
self-assigned this
Jan 17, 2019
FiloSottile
referenced this issue
Jan 17, 2019
Closed
crypto/tls: reported "internal errors" are just user errors misdiagnosed #29779
FiloSottile
removed
the
release-blocker
label
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
FiloSottile commentedJan 17, 2019
A (weird, non-Go) client that prefers
PSSWithSHA512(minimum key size 1040 bits) but supportsPSSWithSHA256(minimum key size 528 bits) would fail to connect to a Go server with a certificate with a 1024 bit key.We should refuse to negotiate parameters that we already know are not supported by the certificate key.
See #29779 (comment)