Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: don't negotiate RSA-PSS algorithms that are too big for our key #29793

Open
FiloSottile opened this issue Jan 17, 2019 · 1 comment

Comments

@FiloSottile
Copy link
Member

commented Jan 17, 2019

A (weird, non-Go) client that prefers PSSWithSHA512 (minimum key size 1040 bits) but supports PSSWithSHA256 (minimum key size 528 bits) would fail to connect to a Go server with a certificate with a 1024 bit key.

We should refuse to negotiate parameters that we already know are not supported by the certificate key.

See #29779 (comment)

@FiloSottile FiloSottile added NeedsFix release-blocker labels Jan 17, 2019

@FiloSottile FiloSottile added this to the Go1.13 milestone Jan 17, 2019

@FiloSottile FiloSottile self-assigned this Jan 17, 2019

@FiloSottile FiloSottile referenced this issue Jan 17, 2019
Closed

@FiloSottile FiloSottile removed the release-blocker label Feb 1, 2019

@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019

@FiloSottile

This comment has been minimized.

Sign in to view
Copy link
Member Author

commented Jul 22, 2019 •
edited

This makes sense to tackle along with #32426 and #28660, as well as with updating the certificate selection logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FiloSottile FiloSottile

Labels
NeedsFix
Projects
None yet
Milestone
  Go1.14
2 participants
@FiloSottile @andybons
You can’t perform that action at this time.