New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: cmd/go: 'go mod tidy' should remove stale 'exclude' directives #29813

Open
bcmills opened this Issue Jan 18, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@bcmills
Copy link
Member

bcmills commented Jan 18, 2019

exclude directives in the go.mod file prevent commands such as go get -u from selecting particular versions of modules.

However, if the active version of a dependency is already semantically higher than the excluded version, go get -u would never select that version implicitly in the first place (depending on the resolution of #26474). The only time it could be introduced is by an explicit downgrade of some package, and explicit downgrades — though possible — are likely to be rare in practice.

That makes those exclude directives noisy and somewhat misleading: they appear to have an effect on version selection, but may actually be very stale and completely irrelevant.

I propose that go mod tidy should remove exclude directives if the selected version of the module in question is already higher than the excluded version.

(CC @rsc @jayconrod)

@gopherbot gopherbot added this to the Proposal milestone Jan 18, 2019

@gopherbot gopherbot added the Proposal label Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment