Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: timing out on plan9/386 builder #29822

Closed
0intro opened this issue Jan 18, 2019 · 8 comments

Comments

Projects
None yet
4 participants
@0intro
Copy link
Member

commented Jan 18, 2019

Since the addition of many new tests in cmd/go during the last
few weeks, the cmd/go tests are timing out on the plan9/386
builder running on GCE.

Test "go_test:cmd/go" ran over 20m0s limit (20m0.001784079s)

This is related to CL 158537.

@0intro 0intro added this to the Go1.12 milestone Jan 18, 2019

@0intro 0intro self-assigned this Jan 18, 2019

@bradfitz

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

Sorry, but this is not Go 1.12 material.

The Plan 9 port exists on a best effort basis.

@bradfitz bradfitz modified the milestones: Go1.12, Unplanned Jan 18, 2019

@bcmills

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

Are they that slow even in -short mode?

Is there something about plan9 that makes operations dramatically slower than everywhere else? (go test -short cmd/go currently takes ~37s on my 6-core workstation.)

@bcmills

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

Or is there something deadlocking in the test?

@0intro

This comment has been minimized.

Copy link
Member Author

commented Jan 18, 2019

File I/O are slow on Plan 9. There was a deadlock in ramfs related to the use of the lockfile package, but I fixed in November (issue #29033). Now, the cmd/go tests complete, but it takes more than 20m (the coordinator timeout) to complete on GCE.

I plan to enable SMP on the Plan 9 image, so the cmd/go tests could complete significantly faster.

@gopherbot

This comment has been minimized.

Copy link

commented Jan 18, 2019

Change https://golang.org/cl/158597 mentions this issue: env: enable SMP in Plan 9 image

@gopherbot

This comment has been minimized.

Copy link

commented Jan 18, 2019

Change https://golang.org/cl/158541 mentions this issue: dashboard: bump plan9 GCE image

@bradfitz

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

Deployed & cleared the plan 9 column again. Let's see what happens.

gopherbot pushed a commit to golang/build that referenced this issue Jan 18, 2019

dashboard: bump plan9 GCE image
Includes CL 158597 (enable SMP in Plan 9 image)

Updates golang/go#29822

Change-Id: Ic158c5153e79635ff1bc877d5dfb12a98f380d50
Reviewed-on: https://go-review.googlesource.com/c/158541
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@gopherbot

This comment has been minimized.

Copy link

commented Jan 18, 2019

Change https://golang.org/cl/158542 mentions this issue: env/plan9: revert SMP changes, stop running cmd/go tests

gopherbot pushed a commit to golang/build that referenced this issue Jan 18, 2019

env/plan9: revert SMP changes, stop running cmd/go tests
Revert "env: enable SMP in Plan 9 image"
This reverts commit 6478d3e.

Revert "dashboard: bump plan9 GCE image"
This reverts commit ce20899.

Updates golang/go#29822

Change-Id: I47e75d135e092ee9d5a80c66e91c1048c67cd5f6
Reviewed-on: https://go-review.googlesource.com/c/158542
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: David du Colombier <0intro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.