Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools: move cmd/internal/edit to a public package #29824

Open
josharian opened this issue Jan 18, 2019 · 5 comments

Comments

Projects
None yet
5 participants
@josharian
Copy link
Contributor

commented Jan 18, 2019

cmd/internal/edit is incredibly useful when modifying code, particular as compared to manually constructing an AST for go/printer to print. That's not surprising; it is the reason that Russ wrote it. I have a half dozen copies of cmd/internal/edit floating around, so that I can use it tools that I write.

Given its general utility when writing tools, I propose that we move cmd/internal/edit to x/tools, and then vendor it back into core.

@gopherbot gopherbot added this to the Unreleased milestone Jan 18, 2019

@mvdan

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

/cc @rogpeppe

@josharian

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

Ping. I just made yet another copy of this package.

Who is the decision maker for this?

@thepudds

This comment has been minimized.

Copy link

commented May 8, 2019

Hi @mvdan, I see you commented here earlier. Do you know who the decision maker is for this?

@mvdan

This comment has been minimized.

Copy link
Member

commented May 8, 2019

@rsc added the package and @ianlancetaylor approved it. This is used for cmd/cover, so I guess @bcmills could also make a decision here. I'm not sure.

@ianlancetaylor ianlancetaylor modified the milestones: Unreleased, Go1.13 May 8, 2019

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

I changed the milestone so that it will be looked at sooner rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.