Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: new go tool "api" not documented in 1.12 release notes #29836

Closed
ALTree opened this issue Jan 19, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@ALTree
Copy link
Member

commented Jan 19, 2019

Go 1.12 exposes a new tool (go tool api):

$ diff -y -W 80 <(go tool) <(gotip tool)

addr2line				addr2line
				      >	api
asm					asm
buildid					buildid
cgo					cgo
compile					compile
cover					cover
dist					dist
doc					doc
fix					fix
link					link
nm					nm
objdump					objdump
pack					pack
pprof					pprof
test2json				test2json
tour				      <
trace					trace
vet					vet

But the newly exposed tool is not mentioned anywhere in the 1.12 release notes. I guess it should.

@ALTree ALTree added this to the Go1.12 milestone Jan 19, 2019

@ALTree

This comment has been minimized.

Copy link
Member Author

commented Jan 19, 2019

@andybons

This comment has been minimized.

Copy link
Member

commented Jan 20, 2019

Adding release-blocker so we don’t forget about this.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Jan 22, 2019

I'm sure I'm missing something, but when I run go tool with Go 1.5 or later I see api in the list. Is this a change in how the release is packaged?

@ALTree

This comment has been minimized.

Copy link
Member Author

commented Jan 22, 2019

Oh, my bad. I think it's there when you build from the repo, and it's not when you run go tool from the pre-built binaries. On my machine:

  • go1.11 prebuilt binary has no "api" in the list
  • go1.12beta1 prebuilt binary has no "api" in the list
  • the gotip command I tested in the OP is build from source, and has "api" in the list

It's a little surprising, but it doesn't seem to be a 1.12 issue. Leave for you and andybons to decide if this can be closed.

@bradfitz

This comment has been minimized.

Copy link
Member

commented Jan 22, 2019

We haven't shipped the api tool since 2015 (#13030).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.