New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/tip: stopped updating (godoc fails to build due to new dependency that isn't fetched) #29874

Closed
dmitshur opened this Issue Jan 22, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@dmitshur
Copy link
Member

dmitshur commented Jan 22, 2019

go=8d2e65d2/tools=b2f18478: 2019/01/22 16:26:57 installing godoc...
go=8d2e65d2/tools=b2f18478: 2019/01/22 16:26:57 /build/tip/b/gopath/src/golang.org/x/tools/godoc/redirect/redirect.go:22:2: cannot find package "golang.org/x/net/context/ctxhttp" in any of:
        /build/tip/b/go/src/golang.org/x/net/context/ctxhttp (from $GOROOT)
        /build/tip/b/gopath/src/golang.org/x/net/context/ctxhttp (from $GOPATH)
go=8d2e65d2/tools=b2f18478: 2019/01/22 16:26:57 Init failed: go install golang.org/x/tools/cmd/godoc: exit status 1

It's because of CL 157197, which added a new golang.org/x/net/context/ctxhttp dependency to the golang.org/x/tools/godoc/redirect package.

/cc @bradfitz @cnoellekb FYI.

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Jan 22, 2019

As I wrote on chat:

looks like godocBuilder's Init needs to also install x/net in addition to x/tools now.
but really, let's just switch to modules and delete code instead.
we can use the existing private Athens cache

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Jan 22, 2019

Change https://golang.org/cl/158937 mentions this issue: cmd/tip: also fetch x/net repository before building cmd/godoc

@dmitshur

This comment has been minimized.

Copy link
Member Author

dmitshur commented Jan 23, 2019

looks like godocBuilder's Init needs to also install x/net in addition to x/tools now.

That's what was done in CL 158937 for now.

let's just switch to modules and delete code instead

Can you elaborate on what you had mind? In what way would modules be used here? Do you mean once the website uses modules itself, or something else?

bradfitz pushed a commit to bradfitz/build that referenced this issue Feb 1, 2019

cmd/tip: also fetch x/net repository before building cmd/godoc
x/tools/cmd/godoc uses at least one Go package from x/net as of
CL 157197.

Don't add it to signature because we don't want the signature to
change whenever new commits to x/net are pushed, causing tip.golang.org
to be redeployed. This is because x/net is not considered a critical
component of the website at this time, and that's not expected to
change soon.

When the website begins using modules, it will specify the x/net
version precisely and this decision will no longer matter.

Fixes golang/go#29874

Change-Id: I1fa76bb81f8d2ffc2314375e2dfe4898c3af58de
Reviewed-on: https://go-review.googlesource.com/c/158937
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

@dmitshur dmitshur changed the title x/tools/cmd/tip: stopped updating (godoc fails to build due to new dependency that isn't fetched) x/build/cmd/tip: stopped updating (godoc fails to build due to new dependency that isn't fetched) Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment