Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website/internal/dl: store the list of validUsers in a more dynamic way #29898

Open
julieqiu opened this issue Jan 23, 2019 · 4 comments
Open

x/website/internal/dl: store the list of validUsers in a more dynamic way #29898

julieqiu opened this issue Jan 23, 2019 · 4 comments

Comments

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jan 23, 2019

The list of validUsers is hardcoded at https://github.com/golang/tools/blob/master/godoc/dl/dl.go#L317. This means that every time someone is doing a release for a first time, we need to make a CL to add them to this list (so that they can run the release command) and redeploy golang.org.

We may want to store this list in a more dynamic way.

@gopherbot gopherbot added this to the Unreleased milestone Jan 23, 2019
@julieqiu
Copy link
Contributor Author

@julieqiu julieqiu commented Jan 23, 2019

/cc @bradfitz

Loading

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jan 23, 2019

we need to make a CL to add them to this list (so that they can run the release command) and redeploy golang.org

And cherry-pick it to the release branch, IIRC? /cc @dmitshur

Potential places to store this info:

  • GCE metadata
  • GCS text/json file
  • ... ?

I think GCE metadata is my vote.

Loading

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Jan 23, 2019

Or we don't use the gomote-style user authentication and instead use OAuth2-authenticated requests and then check some IAM permission.

/cc @FiloSottile

Loading

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Jan 23, 2019

And cherry-pick it to the release branch, IIRC? /cc @dmitshur

Yes, and then deploy golang.org. This becomes simpler after #29206 is done.

Loading

@dmitshur dmitshur changed the title x/tools/godoc/dl: store the list of validUsers in a more dynamic way x/website/internal/dl: store the list of validUsers in a more dynamic way Mar 25, 2020
@dmitshur dmitshur removed the Tools label Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants