Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/text: tag a more recent commit #29937

Open
hyangah opened this issue Jan 25, 2019 · 1 comment
Open

x/text: tag a more recent commit #29937

hyangah opened this issue Jan 25, 2019 · 1 comment

Comments

@hyangah
Copy link
Contributor

@hyangah hyangah commented Jan 25, 2019

In module mode, golang.org/x/text picks up more than a year old commit
because its tag, though set before module support, follows semver format.
Providing a tag with a more recent commit will help x/text users transitioning to module mode.

$ GOPATH=$(mktemp -d) GO111MODULE=on tipgo list -versions -json -m golang.org/x/text
go: finding golang.org/x/text v0.3.0
{
	"Path": "golang.org/x/text",
	"Version": "v0.3.0",
	"Versions": [
		"v0.1.0",
		"v0.2.0",
		"v0.3.0"
	],
	"Time": "2017-12-14T13:08:43Z"
}
@gopherbot gopherbot added this to the Unreleased milestone Jan 25, 2019
@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Jan 25, 2019

CC @mpvl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.