Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/cgo: -Waddress-of-packed-member warnings poping up with gcc9 in cgo-gcc-prolog [1.11 backport] #29967

Closed
gopherbot opened this issue Jan 28, 2019 · 2 comments

Comments

@gopherbot
Copy link

commented Jan 28, 2019

@ianlancetaylor requested issue #29962 to be considered for backport to the next 1.11 minor release.

@gopherbot please open backport issues

@gopherbot

This comment has been minimized.

Copy link
Author

commented Jan 30, 2019

Change https://golang.org/cl/160449 mentions this issue: [release-branch.go1.11] cmd/cgo: disable GCC 9 warnings triggered by cgo code

gopherbot pushed a commit that referenced this issue Feb 1, 2019
[release-branch.go1.11] cmd/cgo: disable GCC 9 warnings triggered by …
…cgo code

GCC 9 has started emitting warnings when taking the address of a field
in a packed struct may cause a misaligned pointer. We use packed
structs in cgo to ensure that our field layout matches the C
compiler's layout. Our pointers are always aligned, so disable the warning

Updates #29962
Fixes #29967

Change-Id: I7e290a7cf694a2c2958529e340ebed9fcd62089c
Reviewed-on: https://go-review.googlesource.com/c/159859
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
(cherry picked from commit f2a416b)
Reviewed-on: https://go-review.googlesource.com/c/160449
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link
Author

commented Feb 1, 2019

Closed by merging e104ebf to release-branch.go1.11.

@gopherbot gopherbot closed this Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.