Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: x/build/cmd/release: remove godoc for Go 1.13 #30029

Open
bradfitz opened this Issue Jan 31, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@bradfitz
Copy link
Member

bradfitz commented Jan 31, 2019

Split out of #27151 (reduce download sizes), this proposal is to remove godoc (the webserver) from Go 1.13 releases and document that users can go get it instead.

As of Go 1.12, godoc is only a webserver and go doc is the CLI tool.

/cc @dmitshur

@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Feb 6, 2019

I am skeptical about removing batteries like godoc from the go distribution.
People who want to be able to view HTML versions of docs and the spec and other things that are already in-tree should be able to do that, no?

If anything, I think we should be having discussions about what tools are missing from the go distribution, like goimports.

@bradfitz

This comment has been minimized.

Copy link
Member Author

bradfitz commented Feb 12, 2019

I suspect few users use godoc's HTML mode, though. People are always shocked to hear that it's possible or that I use it. As a user of it myself, I'd be fine with it being go get-able if it means smaller downloads.

@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Feb 13, 2019

We discussed this some more. A lot of us use godoc to view package docs and the spec locally but we suspect very few users do. Let's try deleting godoc from cmd/release now, it will be dropped from Go 1.13 beta, and we'll see if we get pushback then.

@rsc rsc modified the milestones: Proposal, Go1.13 Feb 13, 2019

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Feb 13, 2019

Change https://golang.org/cl/162417 mentions this issue: doc/go1.12: note that Go 1.12 is the last release to include godoc

gopherbot pushed a commit that referenced this issue Feb 13, 2019

doc/go1.12: note that Go 1.12 is the last release to include godoc
Updates #30029

Change-Id: I88e09035d675e7a6855ada0262eb42636c9822cc
Reviewed-on: https://go-review.googlesource.com/c/162417
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Feb 13, 2019

Change https://golang.org/cl/162557 mentions this issue: [release-branch.go1.12] doc/go1.12: note that Go 1.12 is the last release to include godoc

gopherbot pushed a commit that referenced this issue Feb 14, 2019

[release-branch.go1.12] doc/go1.12: note that Go 1.12 is the last rel…
…ease to include godoc

Updates #30029

Change-Id: I88e09035d675e7a6855ada0262eb42636c9822cc
Reviewed-on: https://go-review.googlesource.com/c/162417
Reviewed-by: Andrew Bonventre <andybons@golang.org>
(cherry picked from commit 7cf31d8)
Reviewed-on: https://go-review.googlesource.com/c/162557

nebulabox added a commit to nebulabox/go that referenced this issue Feb 18, 2019

doc/go1.12: note that Go 1.12 is the last release to include godoc
Updates golang#30029

Change-Id: I88e09035d675e7a6855ada0262eb42636c9822cc
Reviewed-on: https://go-review.googlesource.com/c/162417
Reviewed-by: Andrew Bonventre <andybons@golang.org>

nebulabox added a commit to nebulabox/go that referenced this issue Feb 20, 2019

doc/go1.12: note that Go 1.12 is the last release to include godoc
Updates golang#30029

Change-Id: I88e09035d675e7a6855ada0262eb42636c9822cc
Reviewed-on: https://go-review.googlesource.com/c/162417
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.