Skip to content

cmd/go: validate GOBIN early as possible #30054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hyangah opened this issue Feb 1, 2019 · 0 comments
Open

cmd/go: validate GOBIN early as possible #30054

hyangah opened this issue Feb 1, 2019 · 0 comments
Labels
GoCommand cmd/go NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. ToolSpeed
Milestone
Backlog

Comments

@hyangah
Copy link
Contributor

hyangah commented Feb 1, 2019 

GO111MODULE=on GOPATH=`mktemp -d` GOBIN=. tipgo get golang.org/x/tools/cmd/godoc
go: finding golang.org/x/tools/cmd/godoc latest
go: finding golang.org/x/tools/cmd latest
go: finding golang.org/x/tools latest
go: downloading golang.org/x/tools v0.0.0-20190131163942-067a2f313b69
go: extracting golang.org/x/tools v0.0.0-20190131163942-067a2f313b69
go: finding golang.org/x/net/context/ctxhttp latest
go: finding golang.org/x/net/context latest
go: finding golang.org/x/net latest
go: downloading golang.org/x/net v0.0.0-20190125091013-d26f9f9a57f3
go: extracting golang.org/x/net v0.0.0-20190125091013-d26f9f9a57f3
cannot install, GOBIN must be an absolute path

In most cases, the module, build caches will kick in and the work will not be completely wasted.
But it would be nice if Go detects such an obvious user error early before starting all the work.

go version devel +faf187fb8e Thu Jan 31 16:55:43 2019 +0000 linux/amd64
@ALTree ALTree added this to the Go1.13 milestone Feb 4, 2019
@ALTree ALTree added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. GoCommand cmd/go labels Feb 4, 2019
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GoCommand cmd/go NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. ToolSpeed
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@rsc @andybons @ALTree @hyangah @bcmills