New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/devapp: doesn't make it clear which subrepo a pending CL belongs to #30096

Closed
dmitshur opened this Issue Feb 5, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@dmitshur
Copy link
Member

dmitshur commented Feb 5, 2019

On the current Go Release Dashboard, there's a Pending CLs section. It groups CLs based on the path prefix in the CL subject:

image

Our commit message formatting rules instruct people to omit subrepo prefix (like "x/crypto/") from CL subjects, since those are used only in the issue tracker.

However, the current release dashboard doesn't display the subrepo, making it hard to find (correctly formatted) CLs for a given subrepo package. For example, see https://groups.google.com/d/msg/golang-dev/j7w5535aLjA/BuE0P-wkFwAJ for a recent occurrence (/cc @bcmills).

I'd like to make a change to better visualize the subrepo that a given CL affects. Here's the proposed fix:

image

It was easy to implement by reusing the logic for doing the subject parsing from gochanges.org.

It also brings a benefit that improperly formatted CL subjects (that don't omit "x/crypto/" prefix) are easier to spot (and fix):

image

/cc @bradfitz @andybons @bcmills

@gopherbot gopherbot added this to the Unreleased milestone Feb 5, 2019

@gopherbot gopherbot added the Builders label Feb 5, 2019

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Feb 5, 2019

SGTM

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Feb 5, 2019

Change https://golang.org/cl/161219 mentions this issue: devapp: display subrepo that CL belongs to

@dmitshur

This comment has been minimized.

Copy link
Member Author

dmitshur commented Feb 5, 2019

I've sent CL 161219 with the fix. It can be previewed on a staging instance:

https://dev-staging.golang.org/release#Pending%20CLs

@dmitshur

This comment has been minimized.

Copy link
Member Author

dmitshur commented Feb 7, 2019

This is deployed to https://dev.golang.org/release by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment